On Fri, 23 Mar 2007, zou lunkai wrote:

Just a question:
Intead of
+       as_environment& env() const
+       {
+               return *_env;
+       }

why not return the pointer:
+       as_environment*  env() const
+       {
+               return  _env;
+       }
then we will change little of the other code.

Well, I have a habit of trying to do too much in one patch. In this case, while I was trying to remove unnecessary direct use of fn_call::env, I figured I'd try to remove the usage entirely. However, that turned out to be way beyond the scope of my patch. By that time, though I had already changed env() to return by reference.. and it turned out to be trivially easy to update the callers.

However, I may change it back to return a pointer, if I can find the time. :)

Bastiaan


_______________________________________________
Gnash-commit mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/gnash-commit

Reply via email to