On Wed, May 23, 2007 at 06:54:43AM +0000, Zou Lunkai wrote: > Log message: > add tests for shapes > .. > http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-ming.all/shape_test.c?cvsroot=gnash&rev=1.1
> + * Copyright (C) 2005, 2006 Free Software Foundation, Inc. 2007 ... > + * > + */ Could you add a description here ? > + // Do these checks mean that shapes are movieclips? > + "xcheck_equals(typeof(sh1), 'movieclip');" > + "xcheck_equals(typeof(sh2), 'movieclip');" I think it just means tyepof(shape) returns 'movieclip'. We should also test typeof(any_other_character). > + // Do these checks mean that we can add variables to shapes? > + "check_equals(sh1.var1, 10);" > + "check_equals(sh2.var2, 20);" Yes, confirmed. > + "xcheck_equals(sh1._x, 0);" > + "xcheck_equals(sh2._x, 0);" _x is unefined I think > + "sh1._x = 0;" > + "sh2._x = 400;" > + "xcheck_equals(sh1._x, 400);" //odd, why??? Now _x is defined (user-defined) > + // Do these checks mean that shapes are *not* movieclips? > + "check_equals(typeof(sh1.getDepth()), 'undefined');" > + "check_equals(typeof(sh2.getDepth()), 'undefined');" > + > + // Do these checks mean that shapes are *not* movieclips? > + "check_equals(typeof(getInstanceAtDepth(-16381)), 'undefined');" > + "check_equals(typeof(getInstanceAtDepth(-16380)), 'undefined');" I think that means ! sh# instanceof MovieClip. --strk; _______________________________________________ Gnash-commit mailing list [email protected] http://lists.gnu.org/mailman/listinfo/gnash-commit
