CVSROOT: /sources/gnash
Module name: gnash
Changes by: Sandro Santilli <strk> 07/07/25 16:27:56
Modified files:
. : ChangeLog
server : as_value.cpp as_value.h
testsuite/actionscript.all: Number.as
Log message:
* server/as_value.h: remove unneeded "container.h" include.
* server/as_value.cpp (equalsSameType): fixed nan comparison.
* testsuite/actionscript.all/Number.as: fixed NaN != NaN test
(should return false). Add NaN == NaN test (should return
true)
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.3827&r2=1.3828
http://cvs.savannah.gnu.org/viewcvs/gnash/server/as_value.cpp?cvsroot=gnash&r1=1.59&r2=1.60
http://cvs.savannah.gnu.org/viewcvs/gnash/server/as_value.h?cvsroot=gnash&r1=1.59&r2=1.60
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/actionscript.all/Number.as?cvsroot=gnash&r1=1.24&r2=1.25
Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.3827
retrieving revision 1.3828
diff -u -b -r1.3827 -r1.3828
--- ChangeLog 25 Jul 2007 16:16:22 -0000 1.3827
+++ ChangeLog 25 Jul 2007 16:27:55 -0000 1.3828
@@ -1,5 +1,12 @@
2007-07-25 Sandro Santilli <[EMAIL PROTECTED]>
+ * server/as_value.h: remove unneeded "container.h" include.
+ * server/as_value.cpp (equalsSameType): fixed nan comparison.
+ * testsuite/actionscript.all/Number.as: fixed NaN != NaN test
+ (should return false). Add NaN == NaN test (should return true)
+
+2007-07-25 Sandro Santilli <[EMAIL PROTECTED]>
+
* server/as_value.cpp: drop lowercase_if_needed, substitute with
the PROPNAME macro.
* server/as_value.h: add a PROPNAME macro to perform the lowercase
Index: server/as_value.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/as_value.cpp,v
retrieving revision 1.59
retrieving revision 1.60
diff -u -b -r1.59 -r1.60
--- server/as_value.cpp 25 Jul 2007 16:16:23 -0000 1.59
+++ server/as_value.cpp 25 Jul 2007 16:27:55 -0000 1.60
@@ -777,7 +777,9 @@
double b = v.m_number_value;
// Nan != NaN
- if ( isnan(a) || isnan(b) ) return false;
+ //if ( isnan(a) || isnan(b) ) return false;
+
+ if ( isnan(a) && isnan(b) ) return true;
// -0.0 == 0.0
if ( (a == -0 && b == 0) || (a == 0 && b == -0) )
return true;
Index: server/as_value.h
===================================================================
RCS file: /sources/gnash/gnash/server/as_value.h,v
retrieving revision 1.59
retrieving revision 1.60
diff -u -b -r1.59 -r1.60
--- server/as_value.h 25 Jul 2007 16:08:23 -0000 1.59
+++ server/as_value.h 25 Jul 2007 16:27:55 -0000 1.60
@@ -15,7 +15,7 @@
// along with this program; if not, write to the Free Software
// Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
-/* $Id: as_value.h,v 1.59 2007/07/25 16:08:23 strk Exp $ */
+/* $Id: as_value.h,v 1.60 2007/07/25 16:27:55 strk Exp $ */
#ifndef GNASH_AS_VALUE_H
#define GNASH_AS_VALUE_H
@@ -24,7 +24,7 @@
#include "config.h"
#endif
-#include "container.h"
+//#include "container.h"
#include "tu_config.h"
#include "smart_ptr.h"
Index: testsuite/actionscript.all/Number.as
===================================================================
RCS file: /sources/gnash/gnash/testsuite/actionscript.all/Number.as,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -b -r1.24 -r1.25
--- testsuite/actionscript.all/Number.as 9 Jul 2007 12:05:25 -0000
1.24
+++ testsuite/actionscript.all/Number.as 25 Jul 2007 16:27:56 -0000
1.25
@@ -26,7 +26,7 @@
// TODO: test with SWF target != 6 (the only one tested so far)
//
-rcsid="$Id: Number.as,v 1.24 2007/07/09 12:05:25 strk Exp $";
+rcsid="$Id: Number.as,v 1.25 2007/07/25 16:27:56 strk Exp $";
#include "check.as"
@@ -90,7 +90,8 @@
check_equals( typeof(NaN), 'number' );
check_equals( typeof(isNaN), 'function' );
check_equals( typeof(isNaN(NaN)), 'boolean' );
-check(NaN != NaN); // TODO: this seems a bogus check, the check should
actually return false
+check(NaN == NaN);
+check(! (NaN != NaN) );
check( isNaN(NaN) );
check_equals( typeof(isNaN(0/0)), 'boolean' );
check( isNaN(0/0) );
_______________________________________________
Gnash-commit mailing list
Gnash-commit@gnu.org
http://lists.gnu.org/mailman/listinfo/gnash-commit
