On Thu, Sep 06, 2007 at 12:21:06PM +0000, Tomas Groth wrote:
> // Check if there is enough data to parse the body of the frame
> if (!_lt.isPositionConfirmed(_lastParsedPosition+15+bodyLength)) return
> false;
>
> + _lastParsedPosition += 15 + bodyLength;
What's 15 ? Could you use a symbolic name for constants ?
> if (tag[0] == AUDIO_TAG) {
> FLVAudioFrame* frame = new FLVAudioFrame;
...
> FLVVideoFrame* frame = new FLVVideoFrame;
...
> _videoInfo = new FLVVideoInfo(codec, width, height, 0
> /*frameRate*/, 0 /*duration*/);
...
> amf::AMF* amfParser = new amf::AMF();
Please document ownership whenever allocating new resources.
Best if stuffed into an auto_ptr.
--strk;
_______________________________________________
Gnash-commit mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/gnash-commit
