On Mon, Oct 29, 2007 at 09:07:35PM +0000, Chad Musick wrote:
Some logging rationalization:
> log_msg(_("ActionCastOp TESTING"));
These kind of messages are better printed using log_debug.
> + if (!obj)
> + {
> + log_msg(_("In ImplementsOp, not an object.\n"));
> + return;
These could be AS coding errors, or malformed SWF error.
Choose one, and wrap as in:
IF_VERBOSE_ASCODING_ERRORS( log_aserror(...) )
IF_VERBOSE_MALFORMED_SWF( log_swferror(...) )
The wrapping allows easy compile-time removal of the messages.
> + log_msg(_("In ImplementsOp, object had no prototype.\n"));
All of log_xxx functions will append a newline themselves, no need for the
final \n
> + fprintf(stderr, "Extending.\n");
log_debug, most likely
--strk;
_______________________________________________
Gnash-commit mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/gnash-commit
