CVSROOT: /sources/gnash Module name: gnash Changes by: Zou Lunkai <zoulunkai> 07/11/08 06:00:20
Modified files: testsuite/misc-swfc.all: opcode_guard_test3.sc Log message: get rid of misleading comments, it was a bad deduction from a bogus tests. Now, all onButtionActions are immune to opcode guard, feel better:) CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-swfc.all/opcode_guard_test3.sc?cvsroot=gnash&r1=1.1&r2=1.2 Patches: Index: opcode_guard_test3.sc =================================================================== RCS file: /sources/gnash/gnash/testsuite/misc-swfc.all/opcode_guard_test3.sc,v retrieving revision 1.1 retrieving revision 1.2 diff -u -b -r1.1 -r1.2 --- opcode_guard_test3.sc 8 Nov 2007 05:29:44 -0000 1.1 +++ opcode_guard_test3.sc 8 Nov 2007 06:00:20 -0000 1.2 @@ -131,7 +131,7 @@ .show b3 as=pressed .on_press: _root.gotoAndPlay(32); - _root.asExecuted5 = true; + _root.asExecuted4 = true; .end .end .put btn1 x=0 y=300 @@ -143,7 +143,7 @@ .del btn1 .frame 32 .action: - _root.check_equals(asExecuted4, false); + _root.check_equals(asExecuted4, true); .end @@ -152,12 +152,6 @@ // remove the button at frame X+2! // observed insane behaviour: // opcode in onButtonPress is NOT guarded by isUnloaded()/isDestroyed() in this case -// comments: -// the behaviour is strange to me! As it is not consistent with test1~3, where -// all opcode guard works as expected. But this is a very common case is real swfs. -// And many of the confusing bugs were caused by the onButtionActions. -// Seems the difference is caused by the removing time of the buttons. test6~8 -// show similar cases. .frame 33 .button btn2 .show b1 as=idle _______________________________________________ Gnash-commit mailing list Gnash-commit@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-commit