CVSROOT: /sources/gnash
Module name: gnash
Changes by: Sandro Santilli <strk> 07/11/15 16:57:24
Modified files:
. : ChangeLog
server : sprite_instance.cpp
testsuite/misc-ming.all: init_action_test.c
testsuite/misc-swfc.all: action_execution_order_test10.sc
movieclip_destruction_test1.sc
registerclass_test3.sc
testsuite/swfdec: PASSING
Log message:
Construct sprite instance at CONSTRUCT event time (not INITIALIZE).
YouTube works, and we push all init actions now.
Testsuite updated after getting many XPASS and no FAIL.
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.4868&r2=1.4869
http://cvs.savannah.gnu.org/viewcvs/gnash/server/sprite_instance.cpp?cvsroot=gnash&r1=1.385&r2=1.386
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-ming.all/init_action_test.c?cvsroot=gnash&r1=1.6&r2=1.7
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-swfc.all/action_execution_order_test10.sc?cvsroot=gnash&r1=1.12&r2=1.13
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-swfc.all/movieclip_destruction_test1.sc?cvsroot=gnash&r1=1.28&r2=1.29
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-swfc.all/registerclass_test3.sc?cvsroot=gnash&r1=1.7&r2=1.8
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/swfdec/PASSING?cvsroot=gnash&r1=1.57&r2=1.58
Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.4868
retrieving revision 1.4869
diff -u -b -r1.4868 -r1.4869
--- ChangeLog 15 Nov 2007 09:44:05 -0000 1.4868
+++ ChangeLog 15 Nov 2007 16:57:23 -0000 1.4869
@@ -1,5 +1,17 @@
2007-11-15 Sandro Santilli <[EMAIL PROTECTED]>
+ * server/sprite_instance.cpp: construct instance on CONSTRUCT
+ event (not INITIALIZE). YouTube works, and we push all init
+ actions now.
+ * testsuite/misc-ming.all/init_action_test.c,
+ testsuite/misc-swfc.all/action_execution_order_test10.sc,
+ testsuite/misc-swfc.all/movieclip_destruction_test1.sc,
+ testsuite/misc-swfc.all/registerclass_test3.sc,
+ testsuite/swfdec/PASSING: Successes due to pushing init
+ actions on queue.
+
+2007-11-15 Sandro Santilli <[EMAIL PROTECTED]>
+
* server/parser/: movie_definition.h, movie_def_impl.{cpp,h},
sprite_definition.h: drop the obsoleted get_init_actions interface.
Index: server/sprite_instance.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/sprite_instance.cpp,v
retrieving revision 1.385
retrieving revision 1.386
diff -u -b -r1.385 -r1.386
--- server/sprite_instance.cpp 15 Nov 2007 08:14:02 -0000 1.385
+++ server/sprite_instance.cpp 15 Nov 2007 16:57:23 -0000 1.386
@@ -2149,7 +2149,8 @@
return false;
}
- if ( id.m_id == event_id::INITIALIZE )
+ //if ( id.m_id == event_id::INITIALIZE )
+ if ( id.m_id == event_id::CONSTRUCT )
{
// Construct as ActionScript object.
// TODO: it could be we need to do this on-demand instead
@@ -2443,7 +2444,7 @@
// Undefining the YOUTUBE_TAKES_PRECEDENCE you'll get
many XPASS
// in our testsuite, and no failures, but youtube would
break.
//
-#define YOUTUBE_TAKES_PRECEDENCE 1
+//#define YOUTUBE_TAKES_PRECEDENCE 1
#ifdef YOUTUBE_TAKES_PRECEDENCE
code->execute();
#else
Index: testsuite/misc-ming.all/init_action_test.c
===================================================================
RCS file: /sources/gnash/gnash/testsuite/misc-ming.all/init_action_test.c,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -b -r1.6 -r1.7
--- testsuite/misc-ming.all/init_action_test.c 22 Sep 2007 21:46:17 -0000
1.6
+++ testsuite/misc-ming.all/init_action_test.c 15 Nov 2007 16:57:24 -0000
1.7
@@ -153,7 +153,7 @@
* to "after" init actions are executed, which would require
* some book keeping in sprite_instance class
*/
- xcheck_equals(mo, "_root.x", "'0+1+2+3+4+5+6+7+8+9+10+11+'");
+ check_equals(mo, "_root.x", "'0+1+2+3+4+5+6+7+8+9+10+11+'");
check_equals(mo, "_root.y", "'var_of_root'");
add_actions(mo, " _root.totals(); stop(); ");
Index: testsuite/misc-swfc.all/action_execution_order_test10.sc
===================================================================
RCS file:
/sources/gnash/gnash/testsuite/misc-swfc.all/action_execution_order_test10.sc,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -b -r1.12 -r1.13
--- testsuite/misc-swfc.all/action_execution_order_test10.sc 14 Nov 2007
13:23:47 -0000 1.12
+++ testsuite/misc-swfc.all/action_execution_order_test10.sc 15 Nov 2007
16:57:24 -0000 1.13
@@ -229,7 +229,7 @@
.frame 9
.action:
check_equals(mc4_onConstruct_executed, true);
- xcheck_equals(mc5_onConstruct_executed, true);
+ check_equals(mc5_onConstruct_executed, true);
.end
.frame 15
Index: testsuite/misc-swfc.all/movieclip_destruction_test1.sc
===================================================================
RCS file:
/sources/gnash/gnash/testsuite/misc-swfc.all/movieclip_destruction_test1.sc,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -b -r1.28 -r1.29
--- testsuite/misc-swfc.all/movieclip_destruction_test1.sc 14 Nov 2007
13:23:47 -0000 1.28
+++ testsuite/misc-swfc.all/movieclip_destruction_test1.sc 15 Nov 2007
16:57:24 -0000 1.29
@@ -249,12 +249,12 @@
_root.xcheck_equals(mc7.__proto__, Object.prototype);
trace(mc6.__proto__); trace(mc7.__proto__);
_root.check_equals(mc6.__proto__, MovieClip.prototype);
- _root.xcheck_equals(mc7.__proto__, MovieClip.prototype);
+ _root.check_equals(mc7.__proto__, MovieClip.prototype);
_root.check_equals(typeof(mc6), 'movieclip'); // Gnash fails because
executes init actions before DLIST tags
_root.check_equals(typeof(mc6.mc61), 'movieclip'); // Gnash fails because
executes init actions before DLIST tags
- _root.xcheck_equals(typeof(mc7), 'movieclip'); // Gnash fails because
executes init actions before DLIST tags
- _root.xcheck_equals(typeof(mc7.mc71), 'movieclip'); // Gnash fails because
executes init actions before DLIST tags
+ _root.check_equals(typeof(mc7), 'movieclip'); // Gnash fails because
executes init actions before DLIST tags
+ _root.check_equals(typeof(mc7.mc71), 'movieclip'); // Gnash fails because
executes init actions before DLIST tags
_root.check_equals(this, _root); // target is the root !
.end
Index: testsuite/misc-swfc.all/registerclass_test3.sc
===================================================================
RCS file: /sources/gnash/gnash/testsuite/misc-swfc.all/registerclass_test3.sc,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -b -r1.7 -r1.8
--- testsuite/misc-swfc.all/registerclass_test3.sc 15 Nov 2007 08:20:22
-0000 1.7
+++ testsuite/misc-swfc.all/registerclass_test3.sc 15 Nov 2007 16:57:24
-0000 1.8
@@ -65,8 +65,8 @@
.initaction id141:
note("root first InitAction of frame1 (where we check if object placed
after is visible)");
- xcheck_equals(typeof(player.movie), 'movieclip');
- xcheck_equals(player.movie.__proto__, MovieClip.prototype);
+ check_equals(typeof(player.movie), 'movieclip');
+ check_equals(player.movie.__proto__, MovieClip.prototype);
.end
// Place sprite id141 and name it as 'player'
@@ -140,13 +140,13 @@
Object.registerClass('libItem2', theClass2);
// Gnash failed by executing init actions before DLIST tags.
- xcheck_equals(typeof(libItem2), 'movieclip');
- xcheck_equals(libItem2.__proto__, MovieClip.prototype);
- xcheck_equals(libItem2.__proto__, MovieClip.prototype);
+ check_equals(typeof(libItem2), 'movieclip');
+ check_equals(libItem2.__proto__, MovieClip.prototype);
+ check_equals(libItem2.__proto__, MovieClip.prototype);
// Childs of libItem2 have also been placed already
// Gnash fails by executing init actions before frame0 tags
- xcheck_equals(typeof(libItem2.child2), 'movieclip');
+ check_equals(typeof(libItem2.child2), 'movieclip');
.end
.put libItem2
Index: testsuite/swfdec/PASSING
===================================================================
RCS file: /sources/gnash/gnash/testsuite/swfdec/PASSING,v
retrieving revision 1.57
retrieving revision 1.58
diff -u -b -r1.57 -r1.58
--- testsuite/swfdec/PASSING 14 Nov 2007 22:56:09 -0000 1.57
+++ testsuite/swfdec/PASSING 15 Nov 2007 16:57:24 -0000 1.58
@@ -186,6 +186,10 @@
height1.swf:245da260d32dbc48a5f38566ee70171b
height3.swf:2b7547493377ae1c0163c8273a4073f7
height4.swf:8d36c180d196b49608f996db21a421bc
+initaction-queue-5.swf:484859f4ef160149fa9c9d12983c9407
+initaction-queue-6.swf:f385d9c91f03feddc78878a240cefce1
+initaction-queue-7.swf:9a9c506965a854a348db7be3701ee4b3
+initaction-queue-8.swf:25879b23adb8c1fa9e132fb3fc8aa8c6
initobject-stack-5.swf:ea2e25b6d62bfda9d718311b67526e76
initobject-stack-7.swf:c1b43bb4d77906e12770302c274fae3f
instance-name-loaded-5.swf:507414bb411ba30305034cf3078e5fa2
_______________________________________________
Gnash-commit mailing list
Gnash-commit@gnu.org
http://lists.gnu.org/mailman/listinfo/gnash-commit
