CVSROOT: /sources/gnash
Module name: gnash
Changes by: Sandro Santilli <strk> 07/12/17 12:32:54
Modified files:
. : ChangeLog
server/asobj : Sound.cpp Sound.h SoundFfmpeg.cpp SoundFfmpeg.h
SoundGst.cpp SoundGst.h
Log message:
don't copy the string passed to loadSound.
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.5193&r2=1.5194
http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/Sound.cpp?cvsroot=gnash&r1=1.24&r2=1.25
http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/Sound.h?cvsroot=gnash&r1=1.7&r2=1.8
http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/SoundFfmpeg.cpp?cvsroot=gnash&r1=1.20&r2=1.21
http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/SoundFfmpeg.h?cvsroot=gnash&r1=1.11&r2=1.12
http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/SoundGst.cpp?cvsroot=gnash&r1=1.14&r2=1.15
http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/SoundGst.h?cvsroot=gnash&r1=1.6&r2=1.7
Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.5193
retrieving revision 1.5194
diff -u -b -r1.5193 -r1.5194
--- ChangeLog 17 Dec 2007 12:09:44 -0000 1.5193
+++ ChangeLog 17 Dec 2007 12:32:53 -0000 1.5194
@@ -1,5 +1,10 @@
2007-12-17 Sandro Santilli <[EMAIL PROTECTED]>
+ * server/asobj/: Sound.{cpp,h}, SoundFfmpeg.{cpp,h},
+ SoundGst.{cpp,h}: don't copy the string passed to loadSound.
+
+2007-12-17 Sandro Santilli <[EMAIL PROTECTED]>
+
* testsuite/libamf.all/test_object.cpp: ISO C++ forbids variable-size
arrays (-pedantic).
Index: server/asobj/Sound.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/asobj/Sound.cpp,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -b -r1.24 -r1.25
--- server/asobj/Sound.cpp 10 Dec 2007 17:45:33 -0000 1.24
+++ server/asobj/Sound.cpp 17 Dec 2007 12:32:54 -0000 1.25
@@ -139,7 +139,7 @@
}
void
-Sound::loadSound(std::string file, bool /*streaming*/)
+Sound::loadSound(const std::string& file, bool /*streaming*/)
{
log_msg(_("%s is still testing!"), __FUNCTION__);
Index: server/asobj/Sound.h
===================================================================
RCS file: /sources/gnash/gnash/server/asobj/Sound.h,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -b -r1.7 -r1.8
--- server/asobj/Sound.h 1 Jul 2007 10:54:30 -0000 1.7
+++ server/asobj/Sound.h 17 Dec 2007 12:32:54 -0000 1.8
@@ -46,7 +46,7 @@
virtual void getPan();
virtual void getTransform();
virtual int getVolume();
- virtual void loadSound(std::string file, bool streaming);
+ virtual void loadSound(const std::string& file, bool streaming);
virtual void setPan();
virtual void setTransform();
virtual void setVolume(int volume);
Index: server/asobj/SoundFfmpeg.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/asobj/SoundFfmpeg.cpp,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -b -r1.20 -r1.21
--- server/asobj/SoundFfmpeg.cpp 14 Dec 2007 09:37:09 -0000 1.20
+++ server/asobj/SoundFfmpeg.cpp 17 Dec 2007 12:32:54 -0000 1.21
@@ -374,7 +374,7 @@
}
void
-SoundFfmpeg::loadSound(std::string file, bool streaming)
+SoundFfmpeg::loadSound(const std::string& file, bool streaming)
{
leftOverData = NULL;
leftOverSize = 0;
Index: server/asobj/SoundFfmpeg.h
===================================================================
RCS file: /sources/gnash/gnash/server/asobj/SoundFfmpeg.h,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -b -r1.11 -r1.12
--- server/asobj/SoundFfmpeg.h 12 Dec 2007 10:23:46 -0000 1.11
+++ server/asobj/SoundFfmpeg.h 17 Dec 2007 12:32:54 -0000 1.12
@@ -70,7 +70,7 @@
~SoundFfmpeg();
- void loadSound(std::string file, bool streaming);
+ void loadSound(const std::string& file, bool streaming);
void start(int offset, int loops);
void stop(int si);
unsigned int getDuration();
Index: server/asobj/SoundGst.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/asobj/SoundGst.cpp,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -b -r1.14 -r1.15
--- server/asobj/SoundGst.cpp 4 Dec 2007 11:45:31 -0000 1.14
+++ server/asobj/SoundGst.cpp 17 Dec 2007 12:32:54 -0000 1.15
@@ -220,7 +220,7 @@
}
void
-SoundGst::loadSound(std::string file, bool streaming)
+SoundGst::loadSound(const std::string& file, bool streaming)
{
pipeline = NULL;
remainingLoops = 0;
Index: server/asobj/SoundGst.h
===================================================================
RCS file: /sources/gnash/gnash/server/asobj/SoundGst.h,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -b -r1.6 -r1.7
--- server/asobj/SoundGst.h 12 Dec 2007 10:23:46 -0000 1.6
+++ server/asobj/SoundGst.h 17 Dec 2007 12:32:54 -0000 1.7
@@ -56,7 +56,7 @@
{}
~SoundGst();
- void loadSound(std::string file, bool streaming);
+ void loadSound(const std::string& file, bool streaming);
void start(int offset, int loops);
void stop(int si);
unsigned int getDuration();
_______________________________________________
Gnash-commit mailing list
Gnash-commit@gnu.org
http://lists.gnu.org/mailman/listinfo/gnash-commit
