Hi Sandro,
Your proposed change looks good to me.
Cheers,
Bastiaan
On Mon, 30 Jan 2017, Sandro Santilli wrote:
Hi Bastiaan, I'm looking at a warning from the compiler while
building Gnash, and both do seem to be logical errors in code
you seem to have added (or ported/copied):
libmedia/gst/swfdec_codec_gst.c:271:60: warning: logical not is only applied
to the left hand side of comparison [-Wlogical-not-parentheses]
if (!gst_element_set_state (dec->bin, GST_STATE_PLAYING) ==
GST_STATE_CHANGE_SUCCESS) {
^
libmedia/gst/swfdec_codec_gst.c:329:60: warning: logical not is only applied
to the left hand side of comparison [-Wlogical-not-parentheses]
if (!gst_element_set_state (dec->bin, GST_STATE_PLAYING) ==
GST_STATE_CHANGE_SUCCESS) {
^
Does that sound as it should be instead:
gst_element_set_state (dec->bin, GST_STATE_PLAYING) !=
GST_STATE_CHANGE_SUCCESS
Please share your thoughts, thank you
--strk;
_______________________________________________
Gnash-dev mailing list
Gnash-dev@gnu.org
https://lists.gnu.org/mailman/listinfo/gnash-dev
