On Sat, 15 Aug 2009 16:11:31 +0200 Sam Geeraerts <[email protected]> wrote:
> Kemmey, Whitney W CIV NSWCDD, K54 schreef: > > The gen-kernel builder script includes the following lines: > > > > # Changes so it'll compile without some modules > > for i in debian/d-i/modules/*; do > > sed -i 's/^\([[^ ?][^ ?]*\)$/\1 ?/' $i > > done > > > > Is the sed command correct? I think this is meant to look for > > every line that contains no spaces or question marks and append > > " ?" to the end of the line. My regular expression skills aren't > > great, but I think it should be: > > > > sed -i 's/^\([^ ?][^ ?]*\)$/\1 ?/' $i > > > > (Removed the first square bracket.) Without this change, I think > > it's expecting the first character to be "[", "^", " ", or "?", > > which I think is incorrect. > > > > Can anyone clarify? > > (Moving to -dev.) > > You're probably right that the regular expression is wrong. Your > correction seems logical, but don't know what the sed script is > actually for. I suppose it's to ensure that every module in > debian/d-i/modules/* has a question mark behind it. However, I > haven't been able to figure out what that means and if that's > necessary. I've run the sed script off a mate. It seems that the [ is misplaced, assuming we are correct about what the script is meant to do. his regex is `sed -i 's/^\([^ ?]+$/\1 ?/' $i` (Afaik its the same as that proposed above) kk -- Karl Goetz, (Kamping_Kaiser / VK5FOSS) Debian contributor / gNewSense Maintainer http://www.kgoetz.id.au No, I won't join your social networking group
signature.asc
Description: PGP signature
_______________________________________________ gNewSense-dev mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/gnewsense-dev
