Hi. I will add the necessary information the next time. Working with open source project is new for my.
On Sun, Apr 6, 2008 at 4:20 PM, Murray Cumming <[EMAIL PROTECTED]> wrote: > I saw that this in now in svn: > > 2008-04-06 Vivien Malerba <[EMAIL PROTECTED]> > > * samples/XSLT/test.xsl: > * samples/XSLT/transform.c: > * libgda-xslt/libgda-xslt.h: > * libgda-xslt/sqlexslt.c: > * libgda-xslt/sql_backend.c: > * libgda-xslt/sql_exslt_internal.c: > * libgda-xslt/sql_backend.h: applied patch from Pawel Cesar Sanjuan > Szklarz to > > add a new function to the xslt extension libgda-xslt > > > I have some comments: > > Please mention function names in the ChangeLog, particularly when adding > functions. It makes it much easier to see what has changed without > reading the .diff itself. > > And if this is meant to be public API (for applications), (or really > even if not) then > a) It should have gtk-doc documentation. We shouldn't accept patches > that add API without documentation. > b) These function names are obviously missing _s to separate the words: > gda_xslt_bk_fun_getvalue > gda_xslt_bk_fun_getnodeset > gda_xslt_bk_fun_checkif > > -- > [EMAIL PROTECTED] > www.murrayc.com > www.openismus.com > > _______________________________________________ gnome-db-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/gnome-db-list
