On 21 March 2014 22:37, Andre Klapper <[email protected]> wrote: > On Sat, 2014-03-22 at 03:41 +0530, Aruna S wrote: >> The following two patches need to be considered for the freeze break: >> >> Patch to include the Help button in the UI, this introduces a UI Change >> https://bug711505.bugzilla-attachments.gnome.org/attachment.cgi?id=272596 >> >> Patch that contains translations of the "_Help" string in all the >> languages that Photos is translated to currently: >> https://bug711505.bugzilla-attachments.gnome.org/attachment.cgi?id=272597 > > > With my release-team hat on I will not give this a +1 for 3.12.0. > (Anybody is free to overrule me, of course.) > > We are now about 72 hours away from 3.12.0 tarball creation. > The proposed commit touches packaging and is a functionality enhancement > (in contrast to e.g. a crasher bugfix). And after merging this patch, > the "help" git branch of gnome-photos would still have to get merged. > > I would love to see this included for 3.12.1 though, if translators are > okay with the one new string ("_Help") which can be taken from existing > GTK+ translations, as in above patch by Aruna.
Ping, is there any chance that we could push this in for 3.12.1? It's ready to go and I've made sure that both the build system patch and translations of the new string apply cleanly on top of the 3.12 branch. _______________________________________________ gnome-doc-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/gnome-doc-list
