On Tue, 19 Dec 2017 22:18:17 +0100 Gunnar Hjalmarsson <[email protected]> wrote:
> On 2017-12-19 19:59, Petr Kovar wrote: > > On Tue, 19 Dec 2017 11:38:09 +0100 Andre Klapper <[email protected]> > > wrote: > >> On Mon, 2017-12-11 at 02:51 +0100, Gunnar Hjalmarsson wrote: > >>> The markup code at gs-browse-web.page includes various > >>> conditionals. However, none of the conditions seems to be > >>> satisfied when converting to the HTML version of the page: > >>> > >>> https://help.gnome.org/users/gnome-help/stable/gs-browse-web.html > >>> > >>> When browsing gs-browse-web.page using yelp it seems to be >>> correctly > >>> rendered, though. > >>> > >>> I don't know where the problem lies. > >> > >> How could the software running behind help.gnome.org know on which > >> exact Linux distribution the user's browser is running? :) I guess > >> it could check the browser's user agent string. Does e.g. Ubuntu > >> patch all the browsers shipped in Ubuntu to include some special > >> "Ubuntu" line in the browsers' user agent strings? > > > > This is indeed a valid issue. The content at > > https://help.gnome.org/users/gnome-help/stable/gs-browse-web.html is > > incomplete and thus broken because the site scripts just call > > yelp-build and serve the output as static HTML on the site, I > > believe. Running yelp-build locally shows that the conditional > > content is dropped from the HTML output. > > Right, that's what I tried to say in my first message, but I was > probably not crystal clear. ;) One way to handle that particular page is > to test also for "target:html"; please see the attached patch. But with > my Ubuntu hat on, I hope for a smarter solution. So, for help.gnome.org we need to target the epiphany-based content, not Firefox. Going with if:else looked like the best solution here, provided distros will implement custom stylesheets for yelp-build when needed: https://git.gnome.org/browse/gnome-getting-started-docs/commit/gnome-help/C/gs-browse-web.page?id=028f600332e994ea07be0cd8c6dfe6ce65774afb Thanks, pk _______________________________________________ gnome-doc-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/gnome-doc-list
