On Mon, 2005-10-17 at 20:45 +0200, Christian Neumair wrote:
> Am Montag, den 17.10.2005, 13:09 +0200 schrieb Alexander Larsson:
> > static gboolean
> > -prompt_authentication (SmbAuthContext *actx)
> > +prompt_authentication (SmbAuthContext *actx,
> > + gboolean *cancelled)
> >
> > This isn't fixing all uses of the old non-pointer cancelled variable.
> > (In particular, it breaks the return value at the end.)
>
> Eeek, I sent an old revision. I´ve actually changed the latter in a
> later revision.
>
> This one additionally initializes cancelled to FALSE in
> prompt_authentication (gcc 4 complains, gcc 3 not), and improves the
> previously bogus DEBUG_SMB macro invocations in perform_authentication.
It still looks the same. prompt_authentication() uses the the cancelled
pointer without dereferencing it and doesn't initialize it.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
[EMAIL PROTECTED] [EMAIL PROTECTED]
He's a fast talking pirate dog-catcher haunted by an iconic dead American
confidante She's a tortured foul-mouthed mermaid from a different time and
place. They fight crime!
_______________________________________________
gnome-vfs-list mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/gnome-vfs-list
