Hi I found a couple of compilation warnings (errors because of default VFS warning flags from jhbuild) on a 64bit machine.
Attached patch fixes it. Not sure if it should be changed for all the GNOME_VFS_FILE_INFO_SET_* macros. ok to commit? -- Rodrigo Moya <[EMAIL PROTECTED]>
? compile ? gnome-vfs-zip ? imported/fnmatch/Makefile ? imported/fnmatch/Makefile.in ? imported/neon/Makefile ? imported/neon/Makefile.in ? modules/inotify-path.loT ? po/stamp-it ? test/test-address ? test/test-parse-ls-lga Index: ChangeLog =================================================================== RCS file: /cvs/gnome/gnome-vfs/ChangeLog,v retrieving revision 1.2319 diff -u -p -r1.2319 ChangeLog --- ChangeLog 11 Dec 2005 20:33:36 -0000 1.2319 +++ ChangeLog 14 Dec 2005 14:52:28 -0000 @@ -1,3 +1,8 @@ +2005-12-14 Rodrigo Moya <[EMAIL PROTECTED]> + + * libgnomevfs/gnome-vfs-file-info.h: changed some macros for 64bit + compilation. + 2005-12-11 John McCutchan <[EMAIL PROTECTED]> * modules/inotify-helper.c: Disable debug messages Index: libgnomevfs/gnome-vfs-file-info.h =================================================================== RCS file: /cvs/gnome/gnome-vfs/libgnomevfs/gnome-vfs-file-info.h,v retrieving revision 1.33 diff -u -p -r1.33 gnome-vfs-file-info.h --- libgnomevfs/gnome-vfs-file-info.h 30 Nov 2005 14:46:49 -0000 1.33 +++ libgnomevfs/gnome-vfs-file-info.h 14 Dec 2005 14:52:29 -0000 @@ -353,8 +353,8 @@ void gnome_vfs_get * Set the symbolic link field in @info to @value. */ #define GNOME_VFS_FILE_INFO_SET_SYMLINK(info, value) \ - (value ? ((info)->flags |= GNOME_VFS_FILE_FLAGS_SYMLINK) \ - : ((info)->flags &= ~GNOME_VFS_FILE_FLAGS_SYMLINK)) + if (value) (info)->flags |= GNOME_VFS_FILE_FLAGS_SYMLINK; \ + else (info)->flags &= ~GNOME_VFS_FILE_FLAGS_SYMLINK; /** * GNOME_VFS_FILE_INFO_LOCAL: @@ -372,9 +372,9 @@ void gnome_vfs_get * * Set the "local file" field in @info to @value. */ -#define GNOME_VFS_FILE_INFO_SET_LOCAL(info, value) \ - (value ? ((info)->flags |= GNOME_VFS_FILE_FLAGS_LOCAL) \ - : ((info)->flags &= ~GNOME_VFS_FILE_FLAGS_LOCAL)) +#define GNOME_VFS_FILE_INFO_SET_LOCAL(info, value) \ + if (value) (info)->flags |= GNOME_VFS_FILE_FLAGS_LOCAL; \ + else (info)->flags &= ~GNOME_VFS_FILE_FLAGS_LOCAL; /**
_______________________________________________ gnome-vfs-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/gnome-vfs-list
