On Thu, 2006-04-06 at 17:15 +0200, Frederic Crozat wrote: > This patch (sorry, it is quite old but I didn't submitted for review on > the mailing list) fixes parsing some keys in Exec fields for .desktop > files which are KDE specific.
I'm a bit hesitant to this part: + /* URIs were not used, add first one as %f */ + if (expanded && (uri_list == *uris)) { + g_string_append_c (expanded_exec, ' '); + expand_macro ('f', expanded_exec, application, uris); + } If we expanded anything (like, say %i) but we didn't consume any uri (i.e. there was no %u, %f or similar in the exec line) we then (and only then) append an implicit %f at the end. Why is this needed? If it is needed, why only when nothing was expanded? =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander Larsson Red Hat, Inc [EMAIL PROTECTED] [EMAIL PROTECTED] He's a scarfaced dishevelled messiah with a robot buddy named Sparky. She's a hard-bitten communist Hell's Angel who hides her beauty behind a pair of thick-framed spectacles. They fight crime! _______________________________________________ gnome-vfs-list mailing list gnome-vfs-list@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-vfs-list