On Fri, 2008-01-18 at 09:31 +0100, Luca Ferretti wrote: > > > > IMHO could be better prepend the program name and the file name (this is > > > the behavior of plain cat(1)) > > > > > > $ gvfs-cat smb://server/file.txt > > > gvfs-cat: smb://server/file.txt: No such file or directory > > > > Yeah, that looks better. > > Done. The only issue is that now the actual output is something like: > > gvfs-cat: uri:///file/name.ext: error opening file: Error > opening file: No such file or directory > > :-( > > Do I've to remove "error opening file" from gvfs-cat?
This is a more general problem of how errors reported in GErrors should look, when you chain them like this (or even more so if you have things like "error doing highlevel op: error doing midlevel op: lowlevel error message"). Take this case, there is an error in the open_file operation, where it can't find the file requested. Should the error from that be "No such file or directory" or "Error opening file: No such file or directory". It sort of depends on the context of how the message is used... Anyway, the patch looks good to commit. _______________________________________________ gnome-vfs-list mailing list gnome-vfs-list@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-vfs-list
