On Thu, Jan 26, 2006 at 07:55:12AM +0100, Julien PUYDT wrote:
> Damien Sandras wrote:
> >>Damien Sandras wrote:
> >>>Julien, can you rename Connect and Disconnect in the statusicon.cpp and
> >>>main.cpp?
> >>Renaming yes, but what to ? "Call" and "Hang-up" ?
> >Yes, but I think it should be "Hang Up".
> 
> See attached patch. Since you're not there, I count on others to comment 
> and tell me if they find it nice enough :-)

The patch looks good to me. I took the liberty of modifying the tool tip
texts as well. The modified patch is attached.

> >But if we receive an incoming call, I guess "Hang Up" is not correct :-/
> >Also, in the incoming call popup, what do we have currently? 
> >Accept/Decline ?
> 
> Reject / Transfer / Accept so it looks good.

The others look good to me too.

Just one small unrelated nitpick though. "Calls History" is not good
English. It should be "Call History", in the menus and in the window title.

-- 
CJ van den Berg

mailto:[EMAIL PROTECTED]
  xmpp:[EMAIL PROTECTED]
   sip:[EMAIL PROTECTED]
diff -ur ekiga.cvs/src/gui/main.cpp ekiga.patched/src/gui/main.cpp
--- ekiga.cvs/src/gui/main.cpp  2006-01-25 11:04:22.000000000 +0100
+++ ekiga.patched/src/gui/main.cpp      2006-01-26 07:49:49.000000000 +0100
@@ -632,7 +632,7 @@
   gtk_tool_item_set_expand (GTK_TOOL_ITEM (item), FALSE);
 
   gtk_tooltips_set_tip (mw->tips, GTK_WIDGET (mw->connect_button), 
-                       _("Enter an URL to call on the left, and click on this 
button to connect to the given URL"), NULL);
+                       _("Enter a URL on the left, and click this button to 
place a call"), NULL);
   
   gtk_toolbar_insert (GTK_TOOLBAR (toolbar), item, -1);
 
@@ -868,10 +868,10 @@
     {
       GTK_MENU_NEW (_("C_all")),
 
-      GTK_MENU_ENTRY("connect", _("C_onnect"), _("Create a new connection"), 
+      GTK_MENU_ENTRY("connect", _("Ca_ll"), _("Place a new call"), 
                     GM_STOCK_CONNECT_16, 'o',
                     GTK_SIGNAL_FUNC (connect_cb), main_window, TRUE),
-      GTK_MENU_ENTRY("disconnect", _("_Disconnect"),
-                    _("Close the current connection"), 
+      GTK_MENU_ENTRY("disconnect", _("_Hang up"),
+                    _("Terminate the current call"), 
                     GM_STOCK_DISCONNECT_16, 'd',
                     GTK_SIGNAL_FUNC (disconnect_cb), NULL, FALSE),
diff -ur ekiga.cvs/src/gui/statusicon.cpp ekiga.patched/src/gui/statusicon.cpp
--- ekiga.cvs/src/gui/statusicon.cpp    2006-01-25 11:04:22.000000000 +0100
+++ ekiga.patched/src/gui/statusicon.cpp        2006-01-26 07:47:44.000000000 
+0100
@@ -96,10 +96,10 @@
 
   static MenuEntry menu [] =
     {
-      GTK_MENU_ENTRY("connect", _("_Connect"), _("Create a new connection"),
+      GTK_MENU_ENTRY("connect", _("_Call"), _("Place a new call"),
                     GM_STOCK_CONNECT_16, 'c',
                     GTK_SIGNAL_FUNC (connect_cb), main_window, TRUE),
-      GTK_MENU_ENTRY("disconnect", _("_Disconnect"),
-                    _("Close the current connection"),
+      GTK_MENU_ENTRY("disconnect", _("_Hang up"),
+                    _("Terminate the current call"),
                     GM_STOCK_DISCONNECT_16, 'd',
                     GTK_SIGNAL_FUNC (disconnect_cb), NULL, FALSE),

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Gnomemeeting-devel-list mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/gnomemeeting-devel-list

Reply via email to