John A Meinel <[EMAIL PROTECTED]> writes: > There was only one thing I didn't really understand. The first line > in arch_recycle_library, you call: > arch_library_add (chatter_fd, 1, arch, arch_patch_id_revision(revision), > NULL, NULL, -1, 0); > > Isn't that saying "add the revision I am about to add"? Shouldn't it be: > arch_library_add (chatter_fd, 1, arch, arch_patch_id_revision(prev_revision), > NULL, NULL, -1, 0);
Yes. This had already been fixed in the next patch. Sorry for loosing your time with a wrong URL :-( > I would add a "--no-greedy-commit" and make greedy the default. Noted. (but stays very low priority for me) > Also, I didn't see a place where it handles the case where you *don't* > have a greedy revision library setup, so there is no library which wants > to receive the new changeset. It seems to assume that there will be a > place for it. This also should be in the last patches. However, I'm not sure how multiple revision libraries are managed. -- Matthieu _______________________________________________ Gnu-arch-users mailing list [email protected] http://lists.gnu.org/mailman/listinfo/gnu-arch-users GNU arch home page: http://savannah.gnu.org/projects/gnu-arch/
