[EMAIL PROTECTED] writes:
> Hi,
> here is a second patch for pl17 which gives full support for
> cautionary accidentals.

OK, it looks good.  I think this will go into 1.1 (and Jan's
PS/TeX/GUILE patch comes first, so be prepared for some .rej cleaning up).

> I noticed that Lilypond's status printouts are buffered differently
> now. The [1][2].. are not printed character per character but 
> several lines at a time.

I think this is an artefact of the new ly2dvi script.

> I don't realize how to use any of the predefined contexts to 
> include the instrument names in the staff margin. I guess it 
> should be included in OrchestralScoreContext.


> I think \property Score.timeSignatureStyle = "C" would be
> a good candidate for a default behaviour, what do you think?

Yep, but not in its current implementation ( timeSignatureStyle = "C"
would print C's for every time sig.)

>  Atom
> -Lookup::accidental (int j) const
> +Lookup::accidental (int j, bool cautionary) const
>  {
> -  return afm_find (String ("accidentals") + String ("-") + to_str (j));
> +  Atom a = afm_find (String ("accidentals") + String ("-") + to_str (j));
> +  if (cautionary) 
> +    {
> +      Box b=a.extent();
> +      Atom lparen = afm_find (String ("accidentals") + String ("-("));
> +      lparen.translate_axis(b.x().min(),X_AXIS);
> +      b.unite(lparen.extent());
> +      Atom rparen = afm_find (String ("accidentals") + String ("-)"));
> +      rparen.translate_axis(b.x().max(),X_AXIS);
> +      b.unite(rparen.extent());
> +      a = Atom(lparen.str_ + a.str_ + rparen.str_, b);

This is messy.  Maybe we this should return a Molecule instead.

> +       interline#, interline#);
> +     z1 = (leftindent,h);
> +     z2 = (w-stafflinethickness,0);
> +     z3 = (leftindent,-d);
> +
> +     penpos1(stafflinethickness, 35);
> +     penpos2(2 stafflinethickness, 0);
> +     penpos3(stafflinethickness, -35);
> +
> +     penlabels(1,2,3);
> +     fill z2l{down} .. simple_serif(z3l, z3r, 90) .. z2r{up}
> +     .. simple_serif(z1r, z1l, 90) .. z2l{down} -- cycle;
> +enddef;
> +  
> +fet_beginchar("Right paranthesis", ")", "rightparen")

parenthesis
   ^


-- 

Han-Wen Nienhuys, [EMAIL PROTECTED] ** GNU LilyPond - The Music Typesetter 
      http://www.cs.uu.nl/people/hanwen/lilypond/index.html 

Reply via email to