Rob Browning <[EMAIL PROTECTED]> writes:
> Linas:
>
> You changed all my gncBooleans to ints.
Linas, now that I've looked at the modifications you made to my
traversal functions, I can see that you dramatically changed the
functionality. Not only did you change the size of the return type,
but you also changed the semantics of the callback return value to be
nearly exactly the opposite of what I wrote.
Please, if you're going to do something like this, then at least send
me (or the list) a note explaining what you did and why, or *don't
change it*. I just presumed that you hadn't changed the API and was
writing code accordingly.
Now I'm going to have to spend a decent amount of time trying to
figure out what changed, then figure out if those changes broke the
file output code, which they may not have, but since the code worked
just fine when I submitted the patch, I need to investigate that
first...
Bear in mind too that changing stuff this in the engine doesn't just
affect the C code, it can also affects the Guile code, and you have to
make sure to modify gnc.gwp and gnc-helpers.[hc] accordingly.
--
Rob Browning <[EMAIL PROTECTED]> PGP=E80E0D04F521A094 532B97F5D64E3930
----- %< -------------------------------------------- >% ------
The GnuCash / X-Accountant Mailing List
To unsubscribe, send mail to [EMAIL PROTECTED] and
put "unsubscribe gnucash-devel [EMAIL PROTECTED]" in the body
