Rob Browning <[EMAIL PROTECTED]> writes:
> I've got two very big patches for the GNOME version waiting. One's
> from Aleaxndru, and the other's from Heath.
I've looked over and incorporated Alexandru's patch, and I'll be
sending it on to Linas as soon as CVS update is fixed.
Really nice work, Alexandru.
The only comment I had was that you had a dangling else, and those
give me the creeps, so I changed it. i.e.:
if(x) {
foo();
bar();
} else
baz();
I also ignored some (though not all) accidental whitespace changes.
One thing that was painfully clear from seeing what you had to do to
fire up such a nice UI was that we could save a *tremendous* amount of
code if we could write the UI code in guile via a Gtk wrapper like
gnome-guile. The author claims that it's essentially ready for
prime-time, so I might investigate it when I get a chance. Don't
worry, I'm not going to leap into the middle of it anytime soon, but
if it does work well, we should probably debate whether or not we
might want to use it. I suspect that fixing up a dialog like this in
guile would probably take less than a third the code, though I haven't
tried it yet.
Once this is committed, then Heath can generate a new patch, and I'll
get that merged in too.
--
Rob Browning <[EMAIL PROTECTED]> PGP=E80E0D04F521A094 532B97F5D64E3930
----- %< -------------------------------------------- >% ------
The GnuCash / X-Accountant Mailing List
To unsubscribe, send mail to [EMAIL PROTECTED] and
put "unsubscribe gnucash-devel [EMAIL PROTECTED]" in the body
