On Wed, Jul 20, 2005 at 05:08:08PM -0400, Chris Shoemaker wrote: > On Wed, Jul 20, 2005 at 10:54:49PM +0200, Christian Stimming wrote: > > Hi all, > > > > ok, now I've put together a proposal of what can be changed in the > > gnome2-branch. I'd suggest > > > > - removal of acinclude.m4 -- it contains heaps of very old, legacy macros > > > > - adding 2-3 unavoidable legacy macros into file macros/legacy_macros.m4 > > (attached) > > > > - removal of ltmain.sh -- it should be installed by running libtoolize > > > > - changing of macros/autogen.sh, diff attached. > > > > The changes to autogen.sh are > > > > - ACLOCAL_FLAGS="-I $GNOME2_PATH/share/aclocal $ACLOCAL_FLAGS" > > + # if GNOME2_PATH contains several directories, separate them properly > > + TMP_PATH=`echo $GNOME2_PATH | sed 's/:/ -I /g' ` > > + ACLOCAL_FLAGS="-I $TMP_PATH/share/aclocal $ACLOCAL_FLAGS" > > > > to tolerate env variable GNOME2_PATH=/opt/gnome:/usr/bla/bla, and then > > commenting in the libtoolize calls. Oh, and most importantly fix one typo > > > > - macrosdir=`find . -name macros -print` > > + macrodirs=`find . -name macros -print` > > > > If people agree, I would ask to apply this to gnucash-gnome2-dev. I don't > > have > > time anymore and not for this week, so the end-test should be done by > > someone > > else. > > Well, I did volunteer, didn't I? I'll see if I can test this tonight.
Ok, I tested these changes and they pass the autogen/make/make install/execute test. I did notice a couple things. I now see *many* cases of: *** Warning: Linking the shared library FOO.la against the loadable module *** FOO.so is not portable! Where FOO is just about every object in the tree. Also, the 'make install' after a 'make' seemed to take longer than I'm used to, but I may have imagined that. Anyway, despite the warnings, it runs. I didn't test Phil's patch, which looks better, but I don't have GNOME2_PATH set so I wouldn't have noticed. Since it didn't break my build, I recommend this for commitment to g2, with Phil's patch. It'd be nice to squash those warnings, (along with all the GOG CFLAGS warnings) but we can do that later. -chris _______________________________________________ gnucash-devel mailing list [email protected] https://lists.gnucash.org/mailman/listinfo/gnucash-devel
