Quoting Christian Stimming <[EMAIL PROTECTED]>:
The error report from the gentoo guy said that gentoo gets the checkout from
SVN, but will copy that into a different location. So the code is neither
SVN-controlled nor created by "make dist" any longer, and in particular no
file gnc-svninfo.h existed. This rule had no support for this case. I thought
that this if-branch would only be called/trigger if gnc-svninfo.h didn't
exist in the first place, so it didn't make sense to me to rely on such an
existing file. I mean, if this is "make dist", then the rule for
gnc-svninfo.h probably doesn't trigger anyway, does it?
I wish I could see the original error report.
Here's what I was thinking, and you're right, there is one case that I
don't handle (which MIGHT be this case).
Case 1: Normal SVN checkout (this includes an lndir tree).
gnc-svninfo.h may not already exist, .svn directory does exist
the rule calls svnversion and builds the _gnc-svninfo.h file
if the gnc-svninfo.h file exists, compare first before copying.
otherwise, just copy _gnc-svninfo.h to gnc-svninfo.h
Case 2: Build from "dist" tarball.
gnc-svninfo.h will exist. .svn directory does NOT exist.
rule does nothing and uses the provided gnc-svninfo.h
Case 3: (Gentoo case?) -- Checkout from SVN but no .svn subdirs (svn
export?)
gnc-svninfo.h does not exist, .svn directory does not exist either.
This is the case I don't handle. In particular I need to differentiate
this from case #2. The only way to do that is via a test for the
existence of $(srcdir)/gnc-svninfo.h -- if that file exists, then
copy it. If the file does not exist then create one with a bogus version.
If there is a use for this if-clause then you need to add another
test for the
existence of $(srcdir)/gnc-svninfo.h first.
Yep. Need a test for case 3.. Stupid gentoo ebuild people trying to build
from svn.. *grumble* Okay. Can I make the version string:
"you're a stupid gentoo user"? ;)
Christian
-derek
--
Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
Member, MIT Student Information Processing Board (SIPB)
URL: http://web.mit.edu/warlord/ PP-ASEL-IA N1NWH
[EMAIL PROTECTED] PGP key available
_______________________________________________
gnucash-devel mailing list
[email protected]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
