--On December 12, 2006 11:19:24 AM +0100 Christian Stimming <[EMAIL PROTECTED]> wrote:
>>> * You replaced the type names GUID by GNC_GUID and CURRENCY by >>> GNC_CURRENCY, IGNORE by GNC_IGNORE and others. Any reasons for this, >>> especially the latter two? I vaguely recall GUID being defined in >>> some winapi header file, but in SVN-trunk apparently there's no >>> longer a problem with this. >> >> The win32 API header files do define GUID, CURRENCY, and IGNORE. >> The GNC_ versions of these are intended simply to remove this >> colission. > > I think I'll apply some of the name changes that concern only the .c > files. But especially the s/GUID/GNC_GUID/ change concerns a lot of > code, and, as I said, with SVN-trunk we don't observe any problems of > the potential name collision here. I'd suggest to defer this until we > actually run into the problem again. The Windows header files certainly do define those symbols. Is it perhaps the case that SVN-trunk hasn't run into this because it's being built with Cygwin instead of MSVC? Although I did Windows development for years, I haven't looked at the Windows port of Gnucash so this may be off the wall. -- Mike Alexander [EMAIL PROTECTED] Ann Arbor, MI PGP key ID: BEA343A6 _______________________________________________ gnucash-devel mailing list [email protected] https://lists.gnucash.org/mailman/listinfo/gnucash-devel
