Hi Christian, I wonder whether the attached patch is correct and can be applied.
Additionally, do you think it is sensible that I as (aq) newbie try to invest some time on the AqBanking 3 port? I suppose that, unless the patch becomes too large or even excludes AqBanking 2, the results of that port, if someone actually finishes it, are to be backported to branches/2.2? I would mark this one BP then to lessen cluttering and ease merges. Thanks, -- andi5 PS: Cmake will probably have to wait until I have nothing better to do again ;-)
commit 3d25ac1c3a7efbf5e6a765f2e6f18330fa64406a
Author: Andreas Köhler <[EMAIL PROTECTED]>
Date: Mon Mar 17 23:37:29 2008 +0100
Remove some unnessary aqbanking version checks as we depend on >= 1.6.1.
diff --git a/src/import-export/hbci/dialog-hbcitrans.c b/src/import-export/hbci/dialog-hbcitrans.c
index cf97ce9..48fc758 100644
--- a/src/import-export/hbci/dialog-hbcitrans.c
+++ b/src/import-export/hbci/dialog-hbcitrans.c
@@ -33,14 +33,7 @@
#include <aqbanking/account.h>
#include <aqbanking/jobsingletransfer.h>
#include <aqbanking/jobsingledebitnote.h>
-#if ((AQBANKING_VERSION_MAJOR > 1) || \
- ((AQBANKING_VERSION_MAJOR == 1) && \
- ((AQBANKING_VERSION_MINOR > 6) || \
- ((AQBANKING_VERSION_MINOR == 6) && \
- ((AQBANKING_VERSION_PATCHLEVEL > 0) || \
- (AQBANKING_VERSION_BUILD > 2))))))
-# include <aqbanking/jobinternaltransfer.h>
-#endif
+#include <aqbanking/jobinternaltransfer.h>
#include <iconv.h>
#include "dialog-utils.h"
@@ -487,20 +480,12 @@ int gnc_hbci_dialog_run_until_ok(HBCITransDialog *td,
g_warning("gnc_hbci_trans_dialog_enqueue: Oops, job not available. Aborting.\n");
return GTK_RESPONSE_CANCEL;
}
-#if ((AQBANKING_VERSION_MAJOR > 1) || \
- ((AQBANKING_VERSION_MAJOR == 1) && \
- ((AQBANKING_VERSION_MINOR > 0) || \
- ((AQBANKING_VERSION_MINOR == 0) && \
- (AQBANKING_VERSION_PATCHLEVEL > 6)))))
{
const AB_TRANSACTION_LIMITS *joblimits = AB_JobSingleTransfer_GetFieldLimits(job);
max_purpose_lines = (joblimits ?
AB_TransactionLimits_GetMaxLinesPurpose (joblimits) :
2);
}
-#else
- max_purpose_lines = AB_JobSingleTransfer_GetMaxPurposeLines(job);
-#endif
/* these are the number of fields, 27 characters each. */
AB_Job_free(job);
}
@@ -767,15 +752,8 @@ gnc_hbci_trans_dialog_enqueue(const AB_TRANSACTION *hbci_trans, AB_BANKING *api,
job = AB_JobSingleDebitNote_new(h_acc);
break;
case SINGLE_INTERNAL_TRANSFER:
-#if ((AQBANKING_VERSION_MAJOR > 1) || \
- ((AQBANKING_VERSION_MAJOR == 1) && \
- ((AQBANKING_VERSION_MINOR > 6) || \
- ((AQBANKING_VERSION_MINOR == 6) && \
- ((AQBANKING_VERSION_PATCHLEVEL > 0) || \
- (AQBANKING_VERSION_BUILD > 2))))))
job = AB_JobInternalTransfer_new(h_acc);
break;
-#endif
default:
case SINGLE_TRANSFER:
job = AB_JobSingleTransfer_new(h_acc);
@@ -790,15 +768,8 @@ gnc_hbci_trans_dialog_enqueue(const AB_TRANSACTION *hbci_trans, AB_BANKING *api,
AB_JobSingleDebitNote_SetTransaction(job, hbci_trans);
break;
case SINGLE_INTERNAL_TRANSFER:
-#if ((AQBANKING_VERSION_MAJOR > 1) || \
- ((AQBANKING_VERSION_MAJOR == 1) && \
- ((AQBANKING_VERSION_MINOR > 6) || \
- ((AQBANKING_VERSION_MINOR == 6) && \
- ((AQBANKING_VERSION_PATCHLEVEL > 0) || \
- (AQBANKING_VERSION_BUILD > 2))))))
AB_JobInternalTransfer_SetTransaction(job, hbci_trans);
break;
-#endif
default:
case SINGLE_TRANSFER:
AB_JobSingleTransfer_SetTransaction(job, hbci_trans);
diff --git a/src/import-export/hbci/gnc-plugin-hbci.c b/src/import-export/hbci/gnc-plugin-hbci.c
index caf3a8f..e96ae09 100644
--- a/src/import-export/hbci/gnc-plugin-hbci.c
+++ b/src/import-export/hbci/gnc-plugin-hbci.c
@@ -71,14 +71,7 @@ static void gnc_plugin_hbci_cmd_setup (GtkAction *action, GncMainWindowActionDat
static void gnc_plugin_hbci_cmd_get_balance (GtkAction *action, GncMainWindowActionData *data);
static void gnc_plugin_hbci_cmd_get_transactions (GtkAction *action, GncMainWindowActionData *data);
static void gnc_plugin_hbci_cmd_issue_transaction (GtkAction *action, GncMainWindowActionData *data);
-#if ((AQBANKING_VERSION_MAJOR > 1) || \
- ((AQBANKING_VERSION_MAJOR == 1) && \
- ((AQBANKING_VERSION_MINOR > 6) || \
- ((AQBANKING_VERSION_MINOR == 6) && \
- ((AQBANKING_VERSION_PATCHLEVEL > 0) || \
- (AQBANKING_VERSION_BUILD > 2))))))
static void gnc_plugin_hbci_cmd_issue_inttransaction (GtkAction *action, GncMainWindowActionData *data);
-#endif
static void gnc_plugin_hbci_cmd_issue_direct_debit (GtkAction *action, GncMainWindowActionData *data);
static void gnc_plugin_hbci_cmd_mt940_import (GtkAction *action, GncMainWindowActionData *data);
static void gnc_plugin_hbci_cmd_mt942_import (GtkAction *action, GncMainWindowActionData *data);
@@ -108,16 +101,9 @@ static GtkActionEntry gnc_plugin_actions [] = {
{ "HbciIssueTransAction", NULL, N_("_Issue Transaction..."), NULL,
N_("Issue a new transaction online through Online Banking"),
G_CALLBACK (gnc_plugin_hbci_cmd_issue_transaction) },
-#if ((AQBANKING_VERSION_MAJOR > 1) || \
- ((AQBANKING_VERSION_MAJOR == 1) && \
- ((AQBANKING_VERSION_MINOR > 6) || \
- ((AQBANKING_VERSION_MINOR == 6) && \
- ((AQBANKING_VERSION_PATCHLEVEL > 0) || \
- (AQBANKING_VERSION_BUILD > 2))))))
{ "HbciIssueIntTransAction", NULL, N_("I_nternal Transaction..."), NULL,
N_("Issue a new bank-internal transaction online through Online Banking"),
G_CALLBACK (gnc_plugin_hbci_cmd_issue_inttransaction) },
-#endif
{ "HbciIssueDirectDebitAction", NULL, N_("_Direct Debit..."), NULL,
N_("Issue a new direct debit note online through Online Banking"),
G_CALLBACK (gnc_plugin_hbci_cmd_issue_direct_debit) },
@@ -147,23 +133,12 @@ static GtkActionEntry gnc_plugin_actions [] = {
};
static guint gnc_plugin_n_actions = G_N_ELEMENTS (gnc_plugin_actions);
-#if ((AQBANKING_VERSION_MAJOR > 1) || \
- ((AQBANKING_VERSION_MAJOR == 1) && \
- ((AQBANKING_VERSION_MINOR > 6) || \
- ((AQBANKING_VERSION_MINOR == 6) && \
- ((AQBANKING_VERSION_PATCHLEVEL > 0) || \
- (AQBANKING_VERSION_BUILD > 2))))))
-# define INTTRANSACTION "HbciIssueIntTransAction",
-#else
-# define INTTRANSACTION
-#endif
-
static const gchar *account_tree_actions[] = {
"HbciSetupAction",
"HbciGetBalanceAction",
"HbciGetTransAction",
"HbciIssueTransAction",
- INTTRANSACTION
+ "HbciIssueIntTransAction",
"HbciIssueDirectDebitAction",
NULL
};
@@ -173,7 +148,7 @@ static const gchar *register_actions[] = {
"HbciGetBalanceAction",
"HbciGetTransAction",
"HbciIssueTransAction",
- INTTRANSACTION
+ "HbciIssueIntTransAction",
"HbciIssueDirectDebitAction",
NULL
};
@@ -182,7 +157,7 @@ static const gchar *need_account_actions[] = {
"HbciGetBalanceAction",
"HbciGetTransAction",
"HbciIssueTransAction",
- INTTRANSACTION
+ "HbciIssueIntTransAction",
"HbciIssueDirectDebitAction",
NULL
};
@@ -540,12 +515,6 @@ gnc_plugin_hbci_cmd_issue_transaction (GtkAction *action,
LEAVE(" ");
}
-#if ((AQBANKING_VERSION_MAJOR > 1) || \
- ((AQBANKING_VERSION_MAJOR == 1) && \
- ((AQBANKING_VERSION_MINOR > 6) || \
- ((AQBANKING_VERSION_MINOR == 6) && \
- ((AQBANKING_VERSION_PATCHLEVEL > 0) || \
- (AQBANKING_VERSION_BUILD > 2))))))
static void
gnc_plugin_hbci_cmd_issue_inttransaction (GtkAction *action,
GncMainWindowActionData *data)
@@ -562,7 +531,6 @@ gnc_plugin_hbci_cmd_issue_inttransaction (GtkAction *action,
gnc_hbci_maketrans(GTK_WIDGET(data->window), account, SINGLE_INTERNAL_TRANSFER);
LEAVE(" ");
}
-#endif
static void
gnc_plugin_hbci_cmd_issue_direct_debit (GtkAction *action,
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
_______________________________________________ gnucash-devel mailing list [email protected] https://lists.gnucash.org/mailman/listinfo/gnucash-devel
