On Tue, Apr 1, 2008 at 3:15 PM, Charles Day <[EMAIL PROTECTED]> wrote:
> On Tue, Apr 1, 2008 at 1:20 PM, Andreas Köhler <[EMAIL PROTECTED]> wrote: > > > Hi Charles, > > > > Am Dienstag, den 01.04.2008, 13:01 -0700 schrieb Charles Day: > > > I have come up with a working fix for bug > > > 450354<http://bugzilla.gnome.org/show_bug.cgi?id=450354>which involves > > > calling the glib function g_locale_from_utf8(). However, this > > > glib function is not available directly from Scheme unless we add a > > > dependency for guile-slib. To avoid that, I created a C function that > > does > > > the call, then swigified it so that Scheme can use it. A similar > > technique > > > might be used to make a fix for bug > > > 396665<http://bugzilla.gnome.org/show_bug.cgi?id=396665>, > > > by attempting a conversion using g_locale_to_utf8() before resorting > > to the > > > current method (character deletion). > > > > > > So my question is: Is it OK to add this new C function to core-utils, > > as > > > seen in the attached diff? (If so, I will add comments for C and > > doxygen. > > > I've already compiled and tested it.) > > > > I guess that is exactly what is needed and looks just fine. > > Please go commit :-) > > > > Committed the changes to fix bug 450354 as r17062. I'll try fixing bug > 396665 separately. > I've now committed the changes to fix bug 396665 as r17063. In doing so, I created a Scheme predicate named "gnc-utf8?" using SWIG. It would be nice to document the existence of this new Scheme predicate for other developers. Does anyone know if I can just add doxygen-style comments to the SWIG .i file? Will that cause the documentation of this function to appear at http://svn.gnucash.org/docs/HEAD/? Cheers, > Charles > > > > Ciao, > > -- andi5 > > > > > _______________________________________________ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
