--On September 23, 2009 8:05:09 AM -0700 Phil Longstaff
<[email protected]> wrote:
Hmm... should go to the devel list
----- Forwarded Message ----
From: Derek Atkins <[email protected]>
To: Phil Longstaff <[email protected]>
Cc: Mike Alexander <[email protected]>; [email protected];
[email protected] Sent: Wednesday, September 23, 2009 10:15:18 AM
Subject: Re: Multi-currency
Phil,
I don't know. I haven't looked at the patch at all so I don't know
how invasive it is. It would be nice if 2.4.0 knew how to read/write
the extra account types, even if it didn't have all the code in there.
I think it's fine to put it into a feature branch to let people test
it, but I also think that if it's not too invasive, and if it's "off"
by default, it could possibly go into trunk too. But as I said I
haven't looked at it so I don't know how invasive it is.
-derek
I attached a new version of the patch to bug #537476. This version is
based on r18399 which is current as of a few minutes ago. It also
contains one significant change from the previous version. The "use
trading accounts" option has been moved from Edit->Preferences to
File->Properties and has been made a book-local option. The Properties
options contained only business related options, but this seemed to be
the place for file-local options so I added a new pane to this dialog
and put the trading accounts option there. If this is not the right
thing to do it can be moved. I did not make the use of trading
accounts dependent on the existence of a trading account since this
would have made it very difficult to turn them off once they had been
used.
There is a bug in the code that handles boolean options which I
reported as bug #599953. This bug must be fixed too before the new
trading accounts patch will work. I've attached a patch to 599953 to
fix it, but there are other ways it could be fixed.
Let me know if there are any more problems with this.
Mike
_______________________________________________
gnucash-devel mailing list
[email protected]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
