John Ralls <[email protected]> writes: [snip] >> Okay, so key is now NULL, which is fine. But then the second line >> just assigns pkey to the VALUE of key, which means pkey == NULL. > > Got it. That's my GCE. > [...]
GCE? [snip] >> Fair enough. I wonder if we actually NEED the explicit cast? >> If we do then we need to come up with another way of doing it, >> maybe by re-assigning after the fill-in call. > > Yes, otherwise gcc will whine about passing an incompatible pointer. > Googling 'gpointer strict-aliasing' produced > http://www.hulver.com/scoop/story/2004/4/25/13713/0715, > which recommends reassigning, just as you say. I'll add that (along with a > stern comment) shortly. The new patch looks better. > Regards, > John Ralls -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/ PP-ASEL-IA N1NWH [email protected] PGP key available _______________________________________________ gnucash-devel mailing list [email protected] https://lists.gnucash.org/mailman/listinfo/gnucash-devel
