On Wed, 2010-02-24 at 14:37 -0500, Donald Allen wrote: Great! I'll apply the patch. There are probable other places which would benefit from this. There might also be places where the order is unimportant so that the list doesn't need to be reversed.
> BTW, I found the indentation/formatting of this (and other) files to > be very odd, and it rendered the code pretty unreadable for me. What > you see above is a replication of the changes I made to the original > file. In order to do this work, though, I had to format the two > procedures involved (in emacs with meta-ctrl-q) so I could read them > (I could have cleaned them up some more to eliminate unnecessary > pointy-brackets, but didn't bother). It was that code that I actually > tested, so there could be a typo in the above. > > I attribute great importance to code readability and have some strong > opinions about how C code should look. I saw something on > gnucash-devel earlier that gave me the impression there is something > afoot to clean up the code. Is that so? If yes, I'd like to put my > $.02 into that pot. Yes, there is a code formatting effort being made using a standard set of options to a code formatter. They don't match my ideal preferences, but given N people, there will N different tastes. Phil _______________________________________________ gnucash-devel mailing list [email protected] https://lists.gnucash.org/mailman/listinfo/gnucash-devel
