On Wed, Apr 28, 2010 at 1:15 PM, Derek Atkins <[email protected]> wrote: > Geert Janssens <[email protected]> writes: > >> On Wednesday 28 April 2010, Derek Atkins wrote: >>> Geert Janssens <[email protected]> writes: >>> > -GNUCASH_LATEST_STABLE_VERSION="2.2.9" >>> > +GNUCASH_LATEST_STABLE_SERIES=$GNUCASH_MAJOR_VERSION.$(($GNUCASH_MINOR_VE >>> >RSION-($GNUCASH_MINOR_VERSION%2))) >>> >>> This logic will fail when we go from 2.x -> 3.0 >>> >>> I'd rather this be "hard coded" and we just have a list of places where >>> we need to "fix" the release number when we make a new stable release.
I'm going to chime in here. I'm not a gnucash developer, but I can speak from 45 years of professional software development experience. Hard-coding the release number in multiple places and having a list of places to "fix" is doomed to fail. Someone will add a new place where the release number lives and will forget to update the list. Or the release number will change and whoever changes it will forget to go through the list, or get a phone call while doing it, or ...., and not all the places will get changed. I think the release number ought to be in one and only one place, and everything that depends on it should get it from there or from files that are generated by a script from that one source of The Truth. /Don >>> >>> I think we just need a release engineering checklist somewhere (the wiki)? >>> >>> -derek >>> >> I'm not sure it will fail. >> >> The unstable series leading up to 3.0 will be 2.9. While developing 2.9, the >> previous stable series will be 2.8, which will be calculated correctly. >> The next unstable series will be 3.1, and the stable series preceding that >> will correctly be calculated as 3.0. > > Not necessarily. Last time we went from 1.8 -> 1.99 -> 2.0 > >> Geert > > -derek > > -- > Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory > Member, MIT Student Information Processing Board (SIPB) > URL: http://web.mit.edu/warlord/ PP-ASEL-IA N1NWH > [email protected] PGP key available > _______________________________________________ > gnucash-devel mailing list > [email protected] > https://lists.gnucash.org/mailman/listinfo/gnucash-devel > _______________________________________________ gnucash-devel mailing list [email protected] https://lists.gnucash.org/mailman/listinfo/gnucash-devel
