Hi Cristian, On 2010-11-07, at 05:36, Cristian Marchi wrote:
> I have worked on these two files by updating them to latest GnuCash GUI > appearence, by adding a lot of markup and by inserting a new image that shows > the main GnuCash window components. The descriptions of QIF import and > Account hierarchy assistants are also modified to better describe the steps > involved and follow the user during the process. > Can someone review the changes? if no one has comments (I hope you have!) I > will commit the patch at the end of this week. I’m reviewing the patch now. Pretty extensive work! More tagging is always good to see. Just a small query: would it be possible for you to split up your patches into more topical patches (e.g. add tagging, remove extra whitespace, update content), to make review easier. Then later we could always join up the patches and apply them as a single patch (or keep them separate). I know this is sometimes hard to do, but maybe you could give it a shot. I’m actually going to post my proposed changes in the form of a set of patches to be applied on top of your patch, instead of commenting on lines like before. So you can see exactly what I’m suggesting, and most of it should be self-explanatory. I’ll also put a summary of changes on top of each patch to give you an overview. Also, could you take a look at BugZilla bug # 634357,[1] there is going to be a slight rearrangement of the budget menu items before 2.4.0 is released. Do you want to tackle this? Regards, Yawar [1] https://bugzilla.gnome.org/show_bug.cgi?id=634357
PGP.sig
Description: This is a digitally signed message part
_______________________________________________ gnucash-devel mailing list [email protected] https://lists.gnucash.org/mailman/listinfo/gnucash-devel
