Does the caller have any indication that nothing was done?

________________________________
 From: John Ralls <[email protected]>
To: Phil Longstaff <[email protected]> 
Cc: "[email protected] devel" <[email protected]> 
Sent: Sunday, October 28, 2012 7:02:53 PM
Subject: Re: r22465 - gnucash/trunk/src/engine - Allow SchedXaction to safely 
handle having g_object_property_set called on
 

On Oct 28, 2012, at 11:51 AM, Phil Longstaff <[email protected]> wrote:

> How about an else clause in case the value is invalid?

If it's invalid, it does nothing. What would you like it to do?

Regards,
John Ralls

> 
> 
> ________________________________
> From: John Ralls <[email protected]>
> To: [email protected] 
> Sent: Saturday, October 27, 2012 7:30:57 PM
> Subject: r22465 - gnucash/trunk/src/engine - Allow SchedXaction to safely 
> handle having g_object_property_set called on
> 
> Author: jralls
> Date: 2012-10-27 19:30:56 -0400 (Sat, 27 Oct 2012)
> New Revision: 22465
> Trac: http://svn.gnucash.org/trac/changeset/22465
> 
> Modified:
>    gnucash/trunk/src/engine/SchedXaction.c
> Log:
> Allow SchedXaction to safely handle having g_object_property_set called on
> end_date and last_date with invalid GDates.
> 
> 
> This happens routinely when those values are empty and are restored from
> SQL. Thanks to all warnings being fatal when testing, this caused the dbi
> tests to fail.
> 
> [BP]
> 
> _______________________________________________
> gnucash-patches mailing list
> [email protected]
> https://lists.gnucash.org/mailman/listinfo/gnucash-patches
> _______________________________________________
> gnucash-devel mailing list
> [email protected]
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
_______________________________________________
gnucash-devel mailing list
[email protected]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Reply via email to