Geert, Yes, I will look into it and get back to the list.
Alex On Sat, Jan 19, 2013 at 7:06 AM, Geert Janssens <[email protected]> wrote: > Hi Alex, > > I'm impressed with the size of this patch. Unfortunately that also kept me > from reviewing it more thouroughly. :( > > Today I noticed though that this patch causes the Windows build to fail. It > looks like you are introducing a circular dependency between the gnome and > register modules. > > Before your patch, the gnome code already depended on the register code. > > Your patch introduces a new function gnc_find_register_by_account in the > gnome module, used by the register module. So now suddenly the register > module also depends on the gnome module. > > As far as I know this isn't allowed or at least the Windows build doesn't > like it: > > libtool: link: gcc -shared .libs/gnc-ledger-display.o > .libs/gnc-ledger-display2.o .libs/gncmod-ledger-core.o > .libs/split-register.o .libs/split-register-control.o > .libs/split-register-layout.o .libs/split-register-load.o > .libs/split-register-model.o .libs/split-register-model-save.o > .libs/split-register-util.o > -L/C/GCDevel/GC-Native/gnucash/build/src/register/register-core/.libs > -L/C/GCDevel/GC-Native/gnucash/build/src/gnome-utils/.libs > -L/C/GCDevel/GC-Native/gnucash/build/src/backend/xml/.libs > -L/C/GCDevel/GC-Native/gnucash/build/src/app-utils/.libs > -L/C/GCDevel/GC-Native/gnucash/build/src/engine/.libs > -L/C/GCDevel/GC-Native/gnucash/build/src/gnc-module/.libs > -L/C/GCDevel/GC-Native/gnucash/build/src/core-utils/.libs > -L/C/GCDevel/GC-Native/gnucash/build/src/libqof/qof/.libs > -L/C/GCDevel/GC-Native/autotools/lib -L/C/GCDevel/GC-Native/regex/lib > -L/C/GCDevel/GC-Native/gnome/lib -L/C/GCDevel/GC-Native/gmp/lib > -L/C/GCDevel/GC-Native/guile/lib -L/C/GCDevel/GC-Native/libdbi/lib > -L/C/GCDevel/GC-Native/gwenhywfar/ > lib -L/C/GCDevel/GC-Maint/hh/lib -L/C/GCDevel/GC-Native/sqlite3/lib > -L/C/GCDevel/GC-Native/enchant/lib -L/C/GCDevel/GC-Native/libxslt/lib > -L/C/GCDevel/GC-Native/mingw/lib > ../../../src/register/register-gnome/.libs/libgncmod-register-gnome.dll.a > -Lc:/GCDevel/GC-Native/guile/lib -L/C/GCDevel/GC-Native/readline/lib > -Lc:/GCDevel/GC-Native/gnome/lib > /C/GCDevel/GC-Native/gnucash/build/src/register/register-core/.libs/libgncmod-register-core.dll.a > -lgnomecanvas-2 -lart_lgpl_2 > ../../../src/register/register-core/.libs/libgncmod-register-core.dll.a > /C/GCDevel/GC-Native/gnucash/build/src/gnome-utils/.libs/libgncmod-gnome-utils.dll.a > ../../../src/gnome-utils/.libs/libgncmod-gnome-utils.dll.a > /C/GCDevel/GC-Native/gnucash/build/src/backend/xml/.libs/libgnc-backend-xml-utils.dll.a > /C/GCDevel/GC-Native/gnucash/build/src/app-utils/.libs/libgncmod-app-utils.dll.a > /C/GCDevel/GC-Native/gnome/lib/libxml2.dll.a -lz -liconv > ../../../src/app-utils/.libs/libgncmod-app-utils.dll.a > /C/GCDevel/GC-Native/gnucash/build/src/engine/.libs/ > libgncmod-engine.dll.a -lhtmlhelp > ../../../src/engine/.libs/libgncmod-engine.dll.a > /C/GCDevel/GC-Native/gnucash/build/src/gnc-module/.libs/libgnc-module.dll.a > ../../../src/core-utils/.libs/libgnc-core-utils.dll.a > ../../../src/gnc-module/.libs/libgnc-module.dll.a > /C/GCDevel/GC-Native/gnucash/build/src/core-utils/.libs/libgnc-core-utils.dll.a > /C/GCDevel/GC-Native/gnucash/build/src/libqof/qof/.libs/libgnc-qof.dll.a > ../../../src/libqof/qof/.libs/libgnc-qof.dll.a -lgconf-2 > C:/GCDevel/GC-Native/guile/lib/libguile.dll.a -lregex > /C/GCDevel/GC-Native/gmp/lib/libgmp.dll.a -lws2_32 > /C/GCDevel/GC-Native/autotools/lib/libltdl.dll.a -lgtk-win32-2.0 > -lgdk-win32-2.0 -latk-1.0 -lgio-2.0 -lpangowin32-1.0 -lgdi32 > -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lpango-1.0 -lcairo -lgobject-2.0 > -lgthread-2.0 -lgmodule-2.0 -lglib-2.0 -lintl -mms-bitfields -mwindows > -Wl,--enable-auto-import -o .libs/libgncmod-ledger-core.dll > -Wl,--enable-auto-image-base -Xlinker --out-implib -Xlinker > .libs/libgncmod-ledger-core.dll.a > Creating library file: > .libs/libgncmod-ledger-core.dll.a.libs/split-register.o: In function > `gnc_split_register_duplicate_current': > c:/GCDevel/GC-Native/gnucash-git-janssege/src/register/ledger-core/split-register.c:550: > undefined reference to `gnc_find_register_by_account > > Can you look into this ? > > Thanks, > > Geert _______________________________________________ gnucash-devel mailing list [email protected] https://lists.gnucash.org/mailman/listinfo/gnucash-devel
