On Monday 16 December 2013 09:46:30 John Ralls wrote: > On Dec 16, 2013, at 8:51 AM, Geert Janssens <[email protected]> wrote: > > If they should be distributed, we should also add two other m4 files > > I copied from the autoconf archive: > > ax_python_devel.m4 > > ax_swig_python.m4 > > Both are needed for the python bindings. Before I included > > ax_pkg_swig.m4 the python macros were in ac_prog_swig.m4. But that > > file was outdated, so I replaced it with ax_pkg_swig.m4 as > > recommended by the swig manual. > > > > This brings me to another m4 related question I have wanted to ask > > for some time - autogen.sh produces this warning: > > libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to > > configure.ac and libtoolize: rerunning libtoolize, to keep the > > correct libtool macros in-tree. > > > > Should that be 'AC_CONFIG_MACRO_DIR([macros])' in our case, or is m4 > > intended for a different purpose ? > > Well, that explains why you didn’t update Makefile.am. ;-) > > If we need to add a macro to our tree in order to autogen we should > include it in the dist so that others can autogen or autoreconf > configure; that’s sometimes needed to deal with libtool version > conflicts. If that macro is installed into somewhere on aclocal’s > path then we don’t need to distribute it ourselves. > > Yes, if we’re going to mollify libtoolize we should tell it macros > rather than m4; that seems to be where it’s putting its macro files > anyway and if we tell it m4 then we have to provide an m4 in the > dist.
Fixed both issues in r23574. Geert _______________________________________________ gnucash-devel mailing list [email protected] https://lists.gnucash.org/mailman/listinfo/gnucash-devel
