On Jan 14, 2014, at 5:22 AM, alessandro basili <[email protected]> wrote:
> Hi John, > > On 1/13/2014 5:46 PM, John Ralls wrote: > [...] >> We're not terribly concerned about API changes, especially in the >> gnome and gnome-utils directories. Just make sure that if you do >> change a function's signature that you check for and fix both C and >> Scheme callers. > > I do not know Scheme (shame on me! :-)) but I guess checking for the > call wouldn't be an issue. So many languages, so little time. ;-) The function names are the same as the C ones except that words are separated wit '-' instead of '_'. > >> We also need to separate the computations from the >> GUI code in those directories. You don't have to do that yourself, >> but please keep the goal in mind. > > I'm afraid I haven't fully understood this point. Could you elaborate? http://en.wikipedia.org/wiki/Model_view_controller Most current GnuCash code does not separate the controller and view code. We need to fix that. > >> If you can, please add unit tests >> to any functions you alter significantly. > > I would follow recommendations and already existing examples in order to > provide some level of testing. The existing examples aren't all that good, especially outside of src/engine and src/libqof/qof. Regards, John Ralls _______________________________________________ gnucash-devel mailing list [email protected] https://lists.gnucash.org/mailman/listinfo/gnucash-devel
