> On Jul 16, 2017, at 6:51 PM, Alex Aycinena <alex.aycin...@gmail.com> wrote: > > Fix subject on email > > On Sun, Jul 16, 2017 at 6:49 PM, Alex Aycinena <alex.aycin...@gmail.com> > wrote: > >> John, >> >> >> >>> ---------- Forwarded message ---------- >>> From: John Ralls <jra...@ceridwen.us> >>> To: Robert Fewell <14ubo...@gmail.com> >>> Cc: Geert Janssens <geert.gnuc...@kobaltwit.be>, " >>> gnucash-devel@gnucash.org" <gnucash-devel@gnucash.org> >>> Bcc: >>> Date: Sat, 15 Jul 2017 13:59:32 -0700 >>> Subject: Re: gnucash master: Book-Currency Feature step 6 >>> Alex, >>> >>> How many more steps do you have in mind for this feature >> >> >> many >> >> >>> and how long do you think it will take? >> >> >> a long time, because I have spent less time on it than I thought initially >> I could due to other commitments >> >> >>> I ask because it's time to start thinking about setting feature, string, >>> and code freeze dates for 2.8. >>> >>> Regards, >>> John Ralls >>> >>> >> I can easily comment out the changes to File->Properties and then it will >> look like nothing has changed. I can make further changes on a separate >> branch going forward.
Alex, OK, please move to a feature branch. Don’t forget to rebase often so that the merge isn’t messy when you’re eventually ready. As for the visible changes in File->Properties I’d rather that you revert them from master and re-commit them to your feature branch rather than commenting them out. We have far too many blocks of commented-out or if-0-ed code littering the code base. Regards, John Ralls _______________________________________________ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
