Hi Geert, Thanks for fixing it that fast.
Micha On Thu, Oct 05, 2017 at 03:49:31PM +0200, Geert Janssens wrote: > Ok then, fix committed: https://github.com/Gnucash/gnucash/commit/ > 42ac55e03a1a84739f4a5b7a247c31d91c0adc4a > > So this will be fixed in the next stable release. > > Thanks for pointing this out! > > Geert > > On donderdag 5 oktober 2017 03:23:00 CEST John Ralls wrote: > > No, no use case in mind. I think I wrote those tests in a somewhat robotic > > mode, trying to ensure complete test coverage for eventual refactoring of > > the GObject code in the various engine modules. We’ve since decided to drop > > GObject altogether and rewrite the classes in C++, so even if there was a > > reason to test GObject behavior there won’t be one for long. > > > > By all means delete the test. > > > > Regards, > > John Ralls > > > > > On Oct 3, 2017, at 1:47 PM, Geert Janssens <[email protected]> > > > wrote: > > > > > > Hi, > > > > > > I tend to agree with you and I have a patch waiting to be committed to > > > solve this. Before I commit it though I would like to hear from John if > > > he had a particular use case in mind when he chose to add this test. > > > > > > Geert > > > > > > On woensdag 27 september 2017 09:44:29 CEST Micha Lenk wrote: > > >> Dear Gnucash developers, > > >> > > >> The following bug has been reported in the Debian bug tracker as > > >> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=876306 > > >> > > >> I agree that Gnucash tests shouldn't test the behavior of GObject. > > >> Please consider to drop this test. > > >> > > >> Best regards, > > >> Micha > > >> _______________________________________________ gnucash-devel mailing list [email protected] https://lists.gnucash.org/mailman/listinfo/gnucash-devel
