I've just pushed a fix. The non-literal-null-conversion warning is there because it's a common mistake to set char *x = '\0' when one means to say char x = '\0', so my fix just replaced those with NULL, since Alex wants NULL and not "".
Regards, John Ralls > On Jan 25, 2019, at 12:12 PM, Mike Alexander <m...@umich.edu> wrote: > > This commit is causing build failures for me. I get a number of errors of > the form > > /tools/gnucash-git/gnucash/libgnucash/app-utils/gnc-ui-util.c:264:73: > error: expression which evaluates to zero treated as a null pointer constant > of type 'const char *' [-Werror,-Wnon-literal-null-conversion] > qof_book_set_string_option(book, OLD_OPTION_TAXUS_NAME, '\0'); > > I gather others aren’t seeing this. I’m building with the clang from XCode > 10.1 which identifies itself as > > Apple LLVM version 10.0.0 (clang-1000.11.45.5) > Target: x86_64-apple-darwin17.7.0 > Thread model: posix > > If no one else is seeing this I’ll try to figure out what is different for me. > > Mike > >> On Jan 24, 2019, at 9:54 PM, J.Alex Aycinena >> <alex.aycin...@code.gnucash.org> wrote: >> >> Updated via https://github.com/Gnucash/gnucash/commit/fc153643 >> (commit) >> from https://github.com/Gnucash/gnucash/commit/3a486727 (commit) >> >> >> >> commit fc1536432619888dc28cd5c0aa58658094a93c45 >> Author: Alex Aycinena <alex.aycin...@gmail.com> >> Date: Thu Jan 24 18:36:13 2019 -0800 >> >> remove unnecesary 'home' level in path for US Income Tax book tax >> information >> >> >> >> Summary of changes: > > > > _______________________________________________ > gnucash-devel mailing list > gnucash-devel@gnucash.org > https://lists.gnucash.org/mailman/listinfo/gnucash-devel _______________________________________________ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
