Please remember to reply to the mailing list, not the original sender:
http://gnudip2.sourceforge.net/#mailinglist
+++++++++
The backup MX seems to work OK.
But you are correct about the primary MX. A change is not handled
properly.
I have fixed it (in release 2.3.5).
David Yip wrote:
> I'm doing some modification on the GnuDIP code
Do you want to take over maintaining GnuDIP? Or at least share
responsibility? What changes are you making? If you add the new features
to a common version, we may be able to avoid fragmenting the user
community.
I think there are quite a few people who are using hacked versions of
Mike Machado's original version of GnuDIP, and who now cannot easily
upgrade to the new version.
I am tired of looking after this alone. That is why I just keep fixing
release 2.3.5. If I don't, I doubt that I will ever do release 2.3.6, so
it will not get fixed.
> and discover that there may
> be a problem/bug with MX handling. When you change the MX record for a
> user, GnuDIP will keep on adding new MX without deleting the old one.
>
> Here is the code in doreq.pm which handles MX record changes. If I "CHANGE"
> MX or backup MX, $$newinfo{'MXvalue'} and $$newinfo{'MXbackup'} will never
> be empty so no old MX will be deleted.
>
> # add or delete a primary MX?
> if ($$newinfo{'MXvalue'} ne $$oldinfo{'MXvalue'}) {
> if (!$$newinfo{'MXvalue'}) {
> push @oip, (
> "update delete $olddom. MX 100 $$oldinfo{'MXvalue'}");
> push @msg, ("Primary MX DNS record removed for user $olddom");
> } else {
> push @oip, (
> "update add $olddom. $TTL MX 100 $$newinfo{'MXvalue'}");
> push @msg, ("Primary MX DNS record added for user $olddom");
> }
> }
Here is the corrected code:
# add or delete a primary MX?
if ($$newinfo{'MXvalue'} ne $$oldinfo{'MXvalue'}) {
if ($$oldinfo{'MXvalue'}) {
push @oip, (
"update delete $olddom. MX 100 $$oldinfo{'MXvalue'}");
push @msg, ("Primary MX DNS record removed for user $olddom");
}
if ($$newinfo{'MXvalue'}) {
push @oip, (
"update add $olddom. $TTL MX 100 $$newinfo{'MXvalue'}");
push @msg, ("Primary MX DNS record added for user $olddom");
}
}
--
Creighton MacDonnell
http://macdonnell.ca/
--
GnuDIP Mailing List
http://gnudip2.sourceforge.net/#mailinglist
