Arend wrote: > I have more or less completed this conversion, see the patches in ticket > 31: http://trac.gnugo.org/gnugo/ticket/31. While doing this, I found > -Wconversion pretty helpful: > > [...] > > Does anyone see a reason not to set this for GNU Go? (After my changes, > GNU Go again compiles without warnings with -Wconversion included.)
Really? If I do "make clean; make CC='gcc -Wconversion'" I get tons of warnings, like genmove.c: In function 'genmove': genmove.c:244: warning: passing argument 2 of 'do_genmove' as 'float' rather than 'double' due to prototype genmove.c: In function 'genmove_conservative': genmove.c:259: warning: passing argument 2 of 'do_genmove' as 'float' rather than 'double' due to prototype genmove.c: In function 'genmove_restricted': genmove.c:266: warning: passing argument 2 of 'do_genmove' as 'float' rather than 'double' due to prototype genmove.c: In function 'do_genmove': genmove.c:367: warning: passing argument 2 of 'choose_strategy' as 'float' rather than 'double' due to prototype genmove.c:367: warning: passing argument 3 of 'choose_strategy' as 'float' rather than 'double' due to prototype genmove.c:412: warning: passing argument 2 of 'revise_thrashing_dragon' as 'float' rather than 'double' due to prototype genmove.c:412: warning: passing argument 3 of 'revise_thrashing_dragon' as 'float' rather than 'double' due to prototype genmove.c:427: warning: passing argument 4 of 'review_move_reasons' as 'float' rather than 'double' due to prototype Since we are consistently using prototypes I can't see any possible benefits from these warnings. /Gunnar _______________________________________________ gnugo-devel mailing list gnugo-devel@gnu.org http://lists.gnu.org/mailman/listinfo/gnugo-devel
