Unsubscribe me, please 2007/12/16, [EMAIL PROTECTED] <[EMAIL PROTECTED] >: > > Send gnumeric-list mailing list submissions to > [email protected] > > To subscribe or unsubscribe via the World Wide Web, visit > http://mail.gnome.org/mailman/listinfo/gnumeric-list > or, via email, send a message with subject or body 'help' to > [EMAIL PROTECTED] > > You can reach the person managing the list at > [EMAIL PROTECTED] > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of gnumeric-list digest..." > > > Today's Topics: > > 1. Re: Error feedback on graph data selection entries (Jody Goldberg) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Sun, 16 Dec 2007 10:26:30 -0500 > From: Jody Goldberg <[EMAIL PROTECTED]> > Subject: Re: Error feedback on graph data selection entries > To: Emmanuel Pacaud <[EMAIL PROTECTED]> > Cc: gnumeric-list <[email protected]> > Message-ID: <[EMAIL PROTECTED]> > Content-Type: text/plain; charset=us-ascii > > The current behavior is broken, and this seems like a reasonable > solution, but the api worries me. The behaviour should be > consistent across the various prop dialogs. We're also too close to > 1.8.0 to get this properly tested (not your fault). Please update > with the comments below, and we can try get it in for 1.8.1. > > On Sat, Dec 08, 2007 at 08:51:23PM +0100, Emmanuel Pacaud wrote: > > gnm_expr_entry_parse (GnmExprEntry *gee, GnmParsePos const *pp, > > GnmParseError *perr, gboolean start_sel, > > - GnmExprParseFlags flags) > > + GnmExprParseFlags flags, gboolean update_entry) > This is the only piece that gives me pause. > Why do we need different behaviours for update_entry. > > > +static void > > +cb_graph_dim_entry_changed (GnmExprEntry *gee, > > + GraphDimEditor *editor) > > +{ > > + if (!GTK_WIDGET_SENSITIVE (gee) || editor->dataset == NULL) > > + return; > > + > > + get_texpr (editor, NULL); > > +} > > + > > +static void > > +cb_graph_dim_editor_update (GnmExprEntry *gee, > > + G_GNUC_UNUSED gboolean user_requested, > > + GraphDimEditor *editor) > > +{ > > + GnmExprTop const *texpr; > > + > > + /* Ignore changes while we are insensitive. useful for displaying > > + * values, without storing then as Data. Also ignore updates if > the > > + * dataset has been cleared via the weakref handler */ > > + if (!GTK_WIDGET_SENSITIVE (gee) || editor->dataset == NULL) > > + return; > > + > > + if (get_texpr (editor, &texpr)) { > That repeated chunk seems like it belongs in get_texpr > > > +static gboolean > > +get_texpr (GraphDimEditor *editor, GnmExprTop const **new_texpr) > > { > ... > > if (texpr == NULL) { > > + if (editor->data_type == GOG_DATA_SCALAR) { > > + if (new_texpr != NULL) > > texpr = gnm_expr_top_new_constant > ( > > value_new_string > (gnm_expr_entry_get_text (gee))); > Looks like something is missing here. Don't we want to set is_valid > TRUE if texpr != NULL ? > > > > ------------------------------ > > _______________________________________________ > gnumeric-list mailing list > [email protected] > http://mail.gnome.org/mailman/listinfo/gnumeric-list > > > End of gnumeric-list Digest, Vol 44, Issue 7 > ******************************************** >
-- Dear Author(s) please, send me your paper(s): Best regards, Dr. Nikita Khromov-Borisov Associate Professor Medical Faculty Saint Petersburg State University 21 Line, 8 Saint Petersburg 199106 RUSSIA
_______________________________________________ gnumeric-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/gnumeric-list
