Looks good to me. Thanks! BR Martin
> On 1. Sep 2019, at 12:06, Alessio Vanni <[email protected]> wrote: > > Currently, gettext doesn't work for out-of-tree applications. This is > because GNUnet forcibly set the text domain to "GNUnet" (which > apparently is also incorrect), so applications can't be localized unless > their localizations are distributed in-tree by GNUnet itself. > > The attached patch tries to fix this by adding two more fields to > GNUNET_OS_ProjectData: one field is the gettext domain of the > application. As the documentation says, if it's NULL gettext is > disabled so that applications can use their preferred localization > method without having gettext interfering; the other field is > essentially the locale directory, so applications can specify a > different path if they want to, instead of having GNUnet infer it for > them. > > Because some GNUnet libraries also use gettext internally (the util lib > is a prominent example), gettext has to be initialized before the > application takes over. I placed such initialization in > `GNUNET_OS_init' and `GNUNET_OS_project_data_get' because those are two > functions which are very likely to be called (especially the second one, > since it's used in `GNUNET_PROGRAM_run2'.) If there is a better place > (or some places where this is not enough) I can change it and resubmit > it for review. > > I also changed gnunet-ext to keep it consitent with the patch. In > particular, it adds a header which is required for a successful > compilation, so you might want to at least make that change. > > Thank you, > A.V. > > P.S. I'm still not subscribed to the list... yet.
signature.asc
Description: Message signed with OpenPGP
_______________________________________________ GNUnet-developers mailing list [email protected] https://lists.gnu.org/mailman/listinfo/gnunet-developers
