Author: rfm
Date: Tue May 13 12:26:48 2014
New Revision: 37878
URL: http://svn.gna.org/viewcvs/gnustep?rev=37878&view=rev
Log:
fix minor thread safety issue
Modified:
libs/sqlclient/trunk/ChangeLog
libs/sqlclient/trunk/SQLClient.h
libs/sqlclient/trunk/SQLClient.m
Modified: libs/sqlclient/trunk/ChangeLog
URL:
http://svn.gna.org/viewcvs/gnustep/libs/sqlclient/trunk/ChangeLog?rev=37878&r1=37877&r2=37878&view=diff
==============================================================================
--- libs/sqlclient/trunk/ChangeLog (original)
+++ libs/sqlclient/trunk/ChangeLog Tue May 13 12:26:48 2014
@@ -1,3 +1,10 @@
+2014-05-13 Richard Frith-Macdonald <[email protected]>
+
+ * SQLClient.m:
+ Fix tiny window in which a connection could be unlocked yet have
+ the flag set to say it is in a transaction (thus potentially
+ allowing a locking consistency error).
+
2014-05-08 Richard Frith-Macdonald <[email protected]>
* GNUmakefile: new subminor version for bugfix release
Modified: libs/sqlclient/trunk/SQLClient.h
URL:
http://svn.gna.org/viewcvs/gnustep/libs/sqlclient/trunk/SQLClient.h?rev=37878&r1=37877&r2=37878&view=diff
==============================================================================
--- libs/sqlclient/trunk/SQLClient.h (original)
+++ libs/sqlclient/trunk/SQLClient.h Tue May 13 12:26:48 2014
@@ -1134,7 +1134,7 @@
selector: (SEL)aSelector
name: (NSString*)name;
-/** Posts a notification via the dastabase. The name is an SQL identifier
+/** Posts a notification via the database. The name is an SQL identifier
* (for which observers may have registered) and the extra payload
* information may be nil if not required.
*/
Modified: libs/sqlclient/trunk/SQLClient.m
URL:
http://svn.gna.org/viewcvs/gnustep/libs/sqlclient/trunk/SQLClient.m?rev=37878&r1=37877&r2=37878&view=diff
==============================================================================
--- libs/sqlclient/trunk/SQLClient.m (original)
+++ libs/sqlclient/trunk/SQLClient.m Tue May 13 12:26:48 2014
@@ -1079,8 +1079,8 @@
}
NS_HANDLER
{
+ _inTransaction = NO;
[lock unlock];
- _inTransaction = NO;
[localException raise];
}
NS_ENDHANDLER
_______________________________________________
Gnustep-cvs mailing list
[email protected]
https://mail.gna.org/listinfo/gnustep-cvs
