Author: wlux
Date: Tue Jul 12 09:31:22 2016
New Revision: 39976
URL: http://svn.gna.org/viewcvs/gnustep?rev=39976&view=rev
Log:
Fix unsigned comparison to properly detect integer underflows in
UTextNSStringAccess.
Modified:
libs/base/trunk/ChangeLog
libs/base/trunk/Source/GSICUString.m
Modified: libs/base/trunk/ChangeLog
URL:
http://svn.gna.org/viewcvs/gnustep/libs/base/trunk/ChangeLog?rev=39976&r1=39975&r2=39976&view=diff
==============================================================================
--- libs/base/trunk/ChangeLog (original)
+++ libs/base/trunk/ChangeLog Tue Jul 12 09:31:22 2016
@@ -1,3 +1,8 @@
+2016-07-12 Wolfgang Lux <[email protected]>
+
+ * Source/GSICUString.m (UTextNSStringAccess): Fix unsigned
+ comparison to properly detect integer underflows.
+
2016-07-06 Niels Grewe <[email protected]>
* Tests/base/NSRegularExpression/basic.m: Test for -pattern
Modified: libs/base/trunk/Source/GSICUString.m
URL:
http://svn.gna.org/viewcvs/gnustep/libs/base/trunk/Source/GSICUString.m?rev=39976&r1=39975&r2=39976&view=diff
==============================================================================
--- libs/base/trunk/Source/GSICUString.m (original)
+++ libs/base/trunk/Source/GSICUString.m Tue Jul 12 09:31:22 2016
@@ -118,8 +118,11 @@
{
nativeLimit = length;
}
- nativeStart = nativeLimit - chunkSize;
- if (nativeStart < 0)
+ if (nativeLimit >= chunkSize)
+ {
+ nativeStart = nativeLimit - chunkSize;
+ }
+ else
{
nativeStart = 0;
}
_______________________________________________
Gnustep-cvs mailing list
[email protected]
https://mail.gna.org/listinfo/gnustep-cvs
