Author: fredkiefer
Date: Sun Apr 16 13:57:05 2017
New Revision: 40485

URL: http://svn.gna.org/viewcvs/gnustep?rev=40485&view=rev
Log:
        Fix some clang static analyser warnings reported by
        Sebastian Reitenbach <[email protected]>.

Modified:
    libs/back/trunk/ChangeLog
    libs/back/trunk/Source/gsc/GSGState.m
    libs/back/trunk/Source/x11/XGDragView.m
    libs/back/trunk/Source/x11/XGServerWindow.m
    libs/back/trunk/Source/x11/XWindowBuffer.m

Modified: libs/back/trunk/ChangeLog
URL: 
http://svn.gna.org/viewcvs/gnustep/libs/back/trunk/ChangeLog?rev=40485&r1=40484&r2=40485&view=diff
==============================================================================
--- libs/back/trunk/ChangeLog   (original)
+++ libs/back/trunk/ChangeLog   Sun Apr 16 13:57:05 2017
@@ -1,3 +1,12 @@
+2017-04-16  Fred Kiefer <[email protected]>
+
+       * Source/gsc/GSGState.m
+       * Source/x11/XGDragView.m
+       * Source/x11/XGServerWindow.m
+       * Source/x11/XWindowBuffer.m
+       Fix some clang static analyser warnings reported by
+       Sebastian Reitenbach <[email protected]>.
+
 2017-04-04  Ivan Vucica <[email protected]>
 
        * Releasing 0.25.1.

Modified: libs/back/trunk/Source/gsc/GSGState.m
URL: 
http://svn.gna.org/viewcvs/gnustep/libs/back/trunk/Source/gsc/GSGState.m?rev=40485&r1=40484&r2=40485&view=diff
==============================================================================
--- libs/back/trunk/Source/gsc/GSGState.m       (original)
+++ libs/back/trunk/Source/gsc/GSGState.m       Sun Apr 16 13:57:05 2017
@@ -1249,7 +1249,7 @@
       out[0] = out[1] = out[2] = 0.0;
       for (x = NSMinX(rect); x < NSMaxX(rect); x++)
         {
-          char r, g, b, a;
+          unsigned char r, g, b, a;
             
           [function eval: in : out];
      

Modified: libs/back/trunk/Source/x11/XGDragView.m
URL: 
http://svn.gna.org/viewcvs/gnustep/libs/back/trunk/Source/x11/XGDragView.m?rev=40485&r1=40484&r2=40485&view=diff
==============================================================================
--- libs/back/trunk/Source/x11/XGDragView.m     (original)
+++ libs/back/trunk/Source/x11/XGDragView.m     Sun Apr 16 13:57:05 2017
@@ -428,7 +428,7 @@
   NSCountedSet         *drag_set = [self dragTypesForWindow: win];
 
   winNum = [win windowNumber];
-  window = [isa _windowWithTag: winNum];
+  window = [[self class] _windowWithTag: winNum];
 
   GSEnsureDndIsInitialized ();
 

Modified: libs/back/trunk/Source/x11/XGServerWindow.m
URL: 
http://svn.gna.org/viewcvs/gnustep/libs/back/trunk/Source/x11/XGServerWindow.m?rev=40485&r1=40484&r2=40485&view=diff
==============================================================================
--- libs/back/trunk/Source/x11/XGServerWindow.m (original)
+++ libs/back/trunk/Source/x11/XGServerWindow.m Sun Apr 16 13:57:05 2017
@@ -2745,7 +2745,7 @@
     && (window->buffer_width != width || window->buffer_height != height)
     && (window->gdriverProtocol & GDriverHandlesBacking) == 0)
     {
-      [isa waitAllContexts];
+      [[self class] waitAllContexts];
       XFreePixmap(dpy, window->buffer);
       window->buffer = 0;
       if (window->alpha_buffer)
@@ -3623,7 +3623,7 @@
       values.foreground = window->xwn_attrs.background_pixel;
       valuemask = (GCFunction | GCPlaneMask | GCClipMask | GCForeground);
       XChangeGC(dpy, window->gc, valuemask, &values);
-      [isa waitAllContexts];
+      [[self class] waitAllContexts];
       if ((window->gdriverProtocol & GDriverHandlesExpose))
        {
          /* Temporary protocol until we standardize the backing buffer */
@@ -3698,7 +3698,7 @@
 
   if (width > 0 || height > 0)
     {
-      [isa waitAllContexts];
+      [[self class] waitAllContexts];
       if ((window->gdriverProtocol & GDriverHandlesBacking))
        {
          NSDebugLLog (@"XGFlush", 

Modified: libs/back/trunk/Source/x11/XWindowBuffer.m
URL: 
http://svn.gna.org/viewcvs/gnustep/libs/back/trunk/Source/x11/XWindowBuffer.m?rev=40485&r1=40484&r2=40485&view=diff
==============================================================================
--- libs/back/trunk/Source/x11/XWindowBuffer.m  (original)
+++ libs/back/trunk/Source/x11/XWindowBuffer.m  Sun Apr 16 13:57:05 2017
@@ -645,7 +645,7 @@
         while (XCheckTypedEvent(window->display,
           XShmGetEventBase(window->display) + ShmCompletion, &e))
           {
-            [isa _gotShmCompletion: ((XShmCompletionEvent *)&e)->drawable];
+            [[self class] _gotShmCompletion: ((XShmCompletionEvent 
*)&e)->drawable];
           }
       }
     }


_______________________________________________
Gnustep-cvs mailing list
[email protected]
https://mail.gna.org/listinfo/gnustep-cvs

Reply via email to