Quentin, I reverted it again because I found more issues with crashes as did Riccardo Motolla and Andy Ruder with a number of applications. Since Fred made the change, Fred is going to need to determine why he can't see the problem and what the fix is. I will continue to investigate, but I'm not going to leave code in the repository that causes applications to crash. It's one thing if it causes the code to misbehave, it's another when it causes every application I use to crash.
If you would like to investigate it as well, then revert back to the version of NSControl prior to my rollback and try to debug the issue. The applications which fail for me are: Ink, Gorm, and TalkSoup (among others). I prefered testing with Ink, since it's quite small and simple. Later, GJC --Gregory John Casamento ----- Original Message ---- From: Quentin Mathé <[EMAIL PROTECTED]> To: GNUStep Developers <[email protected]> Cc: Gregory John Casamento <[EMAIL PROTECTED]> Sent: Monday, September 4, 2006 4:24:32 AM Subject: Re: [Gnustep-cvs] r23384 - in /libs/gui/trunk: ChangeLog Source/GSStandardWindowDecorationView.m Source/NSControl.m Source/NSWindow.m Le 3 sept. 06 à 18:18, Gregory Casamento a écrit : > Author: gcasa > Date: Sun Sep 3 18:18:42 2006 > New Revision: 23384 > > URL: http://svn.gna.org/viewcvs/gnustep?rev=23384&view=rev > Log: > Reverted previous change. Added comments in NSWindow. > > Modified: > libs/gui/trunk/ChangeLog > libs/gui/trunk/Source/GSStandardWindowDecorationView.m > libs/gui/trunk/Source/NSControl.m > libs/gui/trunk/Source/NSWindow.m Hi Gregory, Why did you revert NSControl change again, did you stumble on an other issue with this change? For the toolbar button, iirc I reimplemented the -mouseDown: method because we cannot currently set an action to be sent on mouseDown event. That's not as common as sending action on mouseUp though, but it's useful. Just to let you know I'm quite interested to have this change reapplied in some way :-) Cheers, Quentin. -- Quentin Mathé [EMAIL PROTECTED] _______________________________________________ Gnustep-dev mailing list [email protected] http://lists.gnu.org/mailman/listinfo/gnustep-dev _______________________________________________ Gnustep-dev mailing list [email protected] http://lists.gnu.org/mailman/listinfo/gnustep-dev
