All this sounds rather nice to me. I love to see code removed without losing functionality.
Fred PS: You may have to sign a copyright assignment for these changes, even when it is mostly removing stuff. Or have you signed one already? Xavier Glattard wrote: > Hi > > I'm ready to post a 'clean' Windows backend to the repository. Few changes but > i dont want to annoy some... ;-) > > And I have some questions. > > Here are the changes : > > - Deletion of all non-GNUstep debug stuff (printf...) > - Deletion of all Notification hooks (used for a debugging purpose) > - Deletion of the Application preference Panel that popups (pops up?) > the 1st time you run _any_ application > - rename GSWINHandlesWindowDecorations and GSWIN32HandlesWindowDecorations > options to GSW32HandlesWindowDecorations (none worked because of a typo). > - use of GSBackHandlesWindowDecorations option like X11 backend > - all these options are read in -initWithAttribute: (no more in > +inializeBackend) and set an instance (not class) variable. > - add methods -handlesWindowDecorations/-setHandlesWindowDecorations > - add methods -usesSystemTaskbar/-setUsesSystemTaskbar > - fixing a bug in W32_GLContext (placement of GL subwindow when > handlesWindowDecoration == YES) > > Here are some questions : > > - Should the backend options be handled by a SystemPreferences module ? > (X11 backend options have no dedicated module) > - in my patch handlesWindowDecoration (like X11?) and usesSystemTaskbar are > set by default : do you agree with these choices ? > - [-stylewindow::] seems not to be used, neither by X11 backend. Delete ? > - GSUseWMStyles option is still present ... have to choose ? > (=GSBackHandlesWindowDecorations=GSW32HandlesWindowDecorations) > - i suggest to rename GSUseWMTaskbar to GSUseSystemTaskbar or anything. > - does the backend runs on 64bits system ? > If it does, why not rename it to MSWin or Win or MSW or something ? > > Thanks for your comments > > Xavier > > > > > > _______________________________________________ > Gnustep-dev mailing list > Gnustep-dev@gnu.org > http://lists.gnu.org/mailman/listinfo/gnustep-dev > _______________________________________________ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
