On Mar 2, 2008, at 1:30 PM, Richard Frith-Macdonald wrote:

On 2 Mar 2008, at 19:20, Tim McIntosh wrote:

Should the #if around NSProprietaryStringEncoding (around line 210) be:

#if OS_API_VERSION(GS_API_NONE,MAC_OS_X_VERSION_10_4)

instead of:

#if     defined(GNUSTEP)

I don't think so ... In MacOS-X NSProprietaryStringEncoding disappears after version 10.4, but in GNUstep it doesn't, and we don't want to disable the code on GNUstep systems.

I guess we don't want to disable it when built on pre-10.5 macOS-X either, so perhaps it should be this ...


#if defined(GNUSTEP) || OS_API_VERSION(GS_API_NONE,MAC_OS_X_VERSION_10_4)

Yeah, I think that makes sense.

Thanks,
-Tim



_______________________________________________
Gnustep-dev mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/gnustep-dev

Reply via email to