I tested the change in a number of different applications and was unable to cause this to occur. I believe this might have been prevent something which was happening under the old architecture of the toolbar.
Gregory Casamento -- Principal Consultant - OLC, Inc # GNUstep Chief Maintainer ________________________________ From: Fred Kiefer <fredkie...@gmx.de> To: Gregory Casamento <greg_casame...@yahoo.com> Cc: GNUstep Developer <gnustep-dev@gnu.org> Sent: Tuesday, February 10, 2009 3:56:00 AM Subject: Re: [Gnustep-cvs] r27827 - in /libs/gui/trunk: ChangeLog Source/NSToolbar.m Gregory Casamento wrote: > Author: gcasa > Date: Tue Feb 10 02:21:07 2009 > New Revision: 27827 > > URL: http://svn.gna.org/viewcvs/gnustep?rev=27827&view=rev > Log: > * Source/NSToolbar.m: (-windowDidUpdate:): Automatically update > the toolbar on every window update. This makes sure that > no matter what window an event happens in the toolbar gets > properly updated for ALL windows. > > Modified: > libs/gui/trunk/ChangeLog > libs/gui/trunk/Source/NSToolbar.m The code you removed claims to avoid a call cycle. Did you make sure that this protection is no longer needed? if (!_inside || _validating || [[NSApp currentEvent] type] == NSMouseMoved) return; // _validating permits in the case the UI/window is refreshed by a validation to // avoid have windowDidUpdate called, which would cause a loop like that : // validate -> view update -> windowDidUpdate -> validate etc. I might well be that it was never needed at all, we just need to make sure things don't get worse through our improvements.
_______________________________________________ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
